Re: [PATCH v2 1/2] mm: reorganize internal_get_user_pages_fast()

2020-10-30 Thread Peter Xu
On Fri, Oct 30, 2020 at 11:46:20AM -0300, Jason Gunthorpe wrote: > The next patch in this series makes the lockless flow a little more > complex, so move the entire block into a new function and remove a level > of indention. Tidy a bit of cruft: > > - addr is always the same as start, so use

Re: [PATCH v2 1/2] mm: reorganize internal_get_user_pages_fast()

2020-10-30 Thread John Hubbard
On 10/30/20 7:46 AM, Jason Gunthorpe wrote: The next patch in this series makes the lockless flow a little more complex, so move the entire block into a new function and remove a level of indention. Tidy a bit of cruft: - addr is always the same as start, so use start - Use the modern

Re: [PATCH v2 1/2] mm: reorganize internal_get_user_pages_fast()

2020-10-30 Thread Jan Kara
On Fri 30-10-20 11:46:20, Jason Gunthorpe wrote: > The next patch in this series makes the lockless flow a little more > complex, so move the entire block into a new function and remove a level > of indention. Tidy a bit of cruft: > > - addr is always the same as start, so use start > > - Use

[PATCH v2 1/2] mm: reorganize internal_get_user_pages_fast()

2020-10-30 Thread Jason Gunthorpe
The next patch in this series makes the lockless flow a little more complex, so move the entire block into a new function and remove a level of indention. Tidy a bit of cruft: - addr is always the same as start, so use start - Use the modern check_add_overflow() for computing end = start + len