Re: [PATCH v2 1/2] mm: use add_page_to_lru_list()/page_lru()/page_off_lru()

2020-09-04 Thread Yu Zhao
On Fri, Sep 04, 2020 at 12:50:01PM +0200, Michal Hocko wrote: > On Thu 03-09-20 21:24:00, Yu Zhao wrote: > > On Thu, Sep 03, 2020 at 10:28:32AM +0200, Michal Hocko wrote: > > > On Mon 31-08-20 11:50:41, Yu Zhao wrote: > > > [...] > > > > @@ -1860,16 +1859,11 @@ static unsigned noinline_for_stack

Re: [PATCH v2 1/2] mm: use add_page_to_lru_list()/page_lru()/page_off_lru()

2020-09-04 Thread Michal Hocko
On Thu 03-09-20 21:24:00, Yu Zhao wrote: > On Thu, Sep 03, 2020 at 10:28:32AM +0200, Michal Hocko wrote: > > On Mon 31-08-20 11:50:41, Yu Zhao wrote: > > [...] > > > @@ -1860,16 +1859,11 @@ static unsigned noinline_for_stack > > > move_pages_to_lru(struct lruvec *lruvec, > > > lruvec =

Re: [PATCH v2 1/2] mm: use add_page_to_lru_list()/page_lru()/page_off_lru()

2020-09-03 Thread Yu Zhao
On Thu, Sep 03, 2020 at 10:28:32AM +0200, Michal Hocko wrote: > On Mon 31-08-20 11:50:41, Yu Zhao wrote: > [...] > > @@ -1860,16 +1859,11 @@ static unsigned noinline_for_stack > > move_pages_to_lru(struct lruvec *lruvec, > > lruvec = mem_cgroup_page_lruvec(page, pgdat); > > > >

Re: [PATCH v2 1/2] mm: use add_page_to_lru_list()/page_lru()/page_off_lru()

2020-09-03 Thread Michal Hocko
On Mon 31-08-20 11:50:41, Yu Zhao wrote: [...] > @@ -1860,16 +1859,11 @@ static unsigned noinline_for_stack > move_pages_to_lru(struct lruvec *lruvec, > lruvec = mem_cgroup_page_lruvec(page, pgdat); > > SetPageLRU(page); > - lru = page_lru(page); > - > -

[PATCH v2 1/2] mm: use add_page_to_lru_list()/page_lru()/page_off_lru()

2020-08-31 Thread Yu Zhao
This is a trivial but worth having clean-up patch. There should be no side effects except page->lru is temporarily poisoned after it's deleted but before it's added to the new list in move_pages_to_lru() (which is not a problem). [ I was under false impression that page_off_lru() clears PG_lru;