Re: [PATCH v2 1/2] mtd: spi-nor: Move m25p80 code in spi-nor.c

2019-07-30 Thread Tudor.Ambarus
On 07/30/2019 09:04 PM, Vignesh Raghavendra wrote: >>> + */ >>> +static int spi_nor_exec_op(struct spi_nor *nor, struct spi_mem_op *op, >>> + u64 *addr, void *buf, size_t len) >>> +{ >>> + int ret; >>> + bool usebouncebuf = false; >> I don't think we need a bounce buffer

Re: [PATCH v2 1/2] mtd: spi-nor: Move m25p80 code in spi-nor.c

2019-07-30 Thread Vignesh Raghavendra
Hi Tudor, On 25-Jul-19 4:49 PM, tudor.amba...@microchip.com wrote: > All, > > I want this in 5.4, please review/test the soonest. > > On 07/20/2019 11:00 AM, Vignesh Raghavendra wrote: > >> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c >> index 03cc788511d5..f428a6d

Re: [PATCH v2 1/2] mtd: spi-nor: Move m25p80 code in spi-nor.c

2019-07-25 Thread Tudor.Ambarus
On 07/25/2019 05:00 PM, Boris Brezillon wrote: > External E-Mail > > > On Thu, 25 Jul 2019 13:17:07 + > wrote: > >> Hi, Boris, >> >> On 07/25/2019 03:37 PM, Boris Brezillon wrote: >>> External E-Mail >>> >>> >>> On Thu, 25 Jul 2019 11:19:06 + >>> wrote: >>> > + */ > +stati

Re: [PATCH v2 1/2] mtd: spi-nor: Move m25p80 code in spi-nor.c

2019-07-25 Thread Boris Brezillon
On Thu, 25 Jul 2019 13:17:07 + wrote: > Hi, Boris, > > On 07/25/2019 03:37 PM, Boris Brezillon wrote: > > External E-Mail > > > > > > On Thu, 25 Jul 2019 11:19:06 + > > wrote: > > > >>> + */ > >>> +static int spi_nor_exec_op(struct spi_nor *nor, struct spi_mem_op *op, > >>> +

Re: [PATCH v2 1/2] mtd: spi-nor: Move m25p80 code in spi-nor.c

2019-07-25 Thread Tudor.Ambarus
On 07/25/2019 04:17 PM, Tudor Ambarus wrote: +static ssize_t spi_nor_spimem_xfer_data(struct spi_nor *nor, + struct spi_mem_op *op, + enum spi_nor_protocol proto) +{ + bool usebouncebuf = false; >>> decl

Re: [PATCH v2 1/2] mtd: spi-nor: Move m25p80 code in spi-nor.c

2019-07-25 Thread Tudor.Ambarus
Hi, Boris, On 07/25/2019 03:37 PM, Boris Brezillon wrote: > External E-Mail > > > On Thu, 25 Jul 2019 11:19:06 + > wrote: > >>> + */ >>> +static int spi_nor_exec_op(struct spi_nor *nor, struct spi_mem_op *op, >>> + u64 *addr, void *buf, size_t len) >>> +{ >>> + int r

Re: [PATCH v2 1/2] mtd: spi-nor: Move m25p80 code in spi-nor.c

2019-07-25 Thread Boris Brezillon
On Thu, 25 Jul 2019 11:19:06 + wrote: > > + */ > > +static int spi_nor_exec_op(struct spi_nor *nor, struct spi_mem_op *op, > > + u64 *addr, void *buf, size_t len) > > +{ > > + int ret; > > + bool usebouncebuf = false; > > I don't think we need a bounce buffer for r

Re: [PATCH v2 1/2] mtd: spi-nor: Move m25p80 code in spi-nor.c

2019-07-25 Thread Tudor.Ambarus
On 07/25/2019 02:19 PM, tudor.amba...@microchip.com wrote: > static int spi_nor_spimem_xfer_reg(struct spi_nor *nor, struct spi_mem_op *op) > { > if (!op || (op->data.nbytes && !nor->cmd_buf)) !nor->cmd_buf can't be NULL, we can get rid of this check too, and use spi_mem_exec_op() directly

Re: [PATCH v2 1/2] mtd: spi-nor: Move m25p80 code in spi-nor.c

2019-07-25 Thread Tudor.Ambarus
All, I want this in 5.4, please review/test the soonest. On 07/20/2019 11:00 AM, Vignesh Raghavendra wrote: > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > index 03cc788511d5..f428a6d4022b 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi

[PATCH v2 1/2] mtd: spi-nor: Move m25p80 code in spi-nor.c

2019-07-20 Thread Vignesh Raghavendra
From: Boris Brezillon The m25p80 driver is actually a generic wrapper around the spi-mem layer. Not only the driver name is misleading, but we'd expect such a common logic to be directly available in the core. Another reason for moving this code is that SPI NOR controller drivers should progressi