Re: [PATCH v2 1/2] net, can, ifi: fix "write buffer full" error

2018-02-08 Thread Marek Vasut
On 02/08/2018 10:33 PM, Marc Kleine-Budde wrote: > On 02/08/2018 08:22 PM, Marek Vasut wrote: >> On 02/08/2018 03:46 PM, Marc Kleine-Budde wrote: >>> On 02/08/2018 07:47 AM, Heiko Schocher wrote: the driver reads in the ISR first the IRQpending register, and clears after that in a write

Re: [PATCH v2 1/2] net, can, ifi: fix "write buffer full" error

2018-02-08 Thread Marek Vasut
On 02/08/2018 10:33 PM, Marc Kleine-Budde wrote: > On 02/08/2018 08:22 PM, Marek Vasut wrote: >> On 02/08/2018 03:46 PM, Marc Kleine-Budde wrote: >>> On 02/08/2018 07:47 AM, Heiko Schocher wrote: the driver reads in the ISR first the IRQpending register, and clears after that in a write

Re: [PATCH v2 1/2] net, can, ifi: fix "write buffer full" error

2018-02-08 Thread Marc Kleine-Budde
On 02/08/2018 08:22 PM, Marek Vasut wrote: > On 02/08/2018 03:46 PM, Marc Kleine-Budde wrote: >> On 02/08/2018 07:47 AM, Heiko Schocher wrote: >>> the driver reads in the ISR first the IRQpending register, >>> and clears after that in a write *all* bits in it. >>> >>> It could happen that the isr

Re: [PATCH v2 1/2] net, can, ifi: fix "write buffer full" error

2018-02-08 Thread Marc Kleine-Budde
On 02/08/2018 08:22 PM, Marek Vasut wrote: > On 02/08/2018 03:46 PM, Marc Kleine-Budde wrote: >> On 02/08/2018 07:47 AM, Heiko Schocher wrote: >>> the driver reads in the ISR first the IRQpending register, >>> and clears after that in a write *all* bits in it. >>> >>> It could happen that the isr

Re: [PATCH v2 1/2] net, can, ifi: fix "write buffer full" error

2018-02-08 Thread Marek Vasut
On 02/08/2018 03:46 PM, Marc Kleine-Budde wrote: > On 02/08/2018 07:47 AM, Heiko Schocher wrote: >> the driver reads in the ISR first the IRQpending register, >> and clears after that in a write *all* bits in it. >> >> It could happen that the isr register raise bits between >> this 2 register

Re: [PATCH v2 1/2] net, can, ifi: fix "write buffer full" error

2018-02-08 Thread Marek Vasut
On 02/08/2018 03:46 PM, Marc Kleine-Budde wrote: > On 02/08/2018 07:47 AM, Heiko Schocher wrote: >> the driver reads in the ISR first the IRQpending register, >> and clears after that in a write *all* bits in it. >> >> It could happen that the isr register raise bits between >> this 2 register

Re: [PATCH v2 1/2] net, can, ifi: fix "write buffer full" error

2018-02-08 Thread Marc Kleine-Budde
On 02/08/2018 07:47 AM, Heiko Schocher wrote: > the driver reads in the ISR first the IRQpending register, > and clears after that in a write *all* bits in it. > > It could happen that the isr register raise bits between > this 2 register accesses, which leads in lost bits ... > > In case it

Re: [PATCH v2 1/2] net, can, ifi: fix "write buffer full" error

2018-02-08 Thread Marc Kleine-Budde
On 02/08/2018 07:47 AM, Heiko Schocher wrote: > the driver reads in the ISR first the IRQpending register, > and clears after that in a write *all* bits in it. > > It could happen that the isr register raise bits between > this 2 register accesses, which leads in lost bits ... > > In case it

[PATCH v2 1/2] net, can, ifi: fix "write buffer full" error

2018-02-07 Thread Heiko Schocher
the driver reads in the ISR first the IRQpending register, and clears after that in a write *all* bits in it. It could happen that the isr register raise bits between this 2 register accesses, which leads in lost bits ... In case it clears "TX message sent successfully", the driver never sends

[PATCH v2 1/2] net, can, ifi: fix "write buffer full" error

2018-02-07 Thread Heiko Schocher
the driver reads in the ISR first the IRQpending register, and clears after that in a write *all* bits in it. It could happen that the isr register raise bits between this 2 register accesses, which leads in lost bits ... In case it clears "TX message sent successfully", the driver never sends