Re: [PATCH v2 1/2] net: Added mtu parameter to dev_forward_skb calls

On Thu, May 11, 2017 at 9:44 PM, Stephen Hemminger wrote: > On Thu, 11 May 2017 21:10:11 +0200 > Fredrik Markström wrote: > >> On Thu, May 11, 2017 at 6:01 PM, Stephen Hemminger >> wrote: >> > On Thu, 11 May

Re: [PATCH v2 1/2] net: Added mtu parameter to dev_forward_skb calls

On Thu, May 11, 2017 at 9:44 PM, Stephen Hemminger wrote: > On Thu, 11 May 2017 21:10:11 +0200 > Fredrik Markström wrote: > >> On Thu, May 11, 2017 at 6:01 PM, Stephen Hemminger >> wrote: >> > On Thu, 11 May 2017 15:46:27 +0200 >> > Fredrik Markstrom wrote: >> > >> >> From: Fredrik Markström

Re: [Bridge] [PATCH v2 1/2] net: Added mtu parameter to dev_forward_skb calls

On Fri, May 12, 2017 at 10:05 AM, Teco Boot wrote: > IP MTU and L2 MTU are different animals. > > IMHO IP MTU is for fragmentation at sender of a link. There is no need > dropping IP packets at receiver with size > configured IP MTU. IP packets > with size > receiver L2 MTU

Re: [Bridge] [PATCH v2 1/2] net: Added mtu parameter to dev_forward_skb calls

On Fri, May 12, 2017 at 10:05 AM, Teco Boot wrote: > IP MTU and L2 MTU are different animals. > > IMHO IP MTU is for fragmentation at sender of a link. There is no need > dropping IP packets at receiver with size > configured IP MTU. IP packets > with size > receiver L2 MTU will be dropped at

Re: [Bridge] [PATCH v2 1/2] net: Added mtu parameter to dev_forward_skb calls

IP MTU and L2 MTU are different animals. IMHO IP MTU is for fragmentation at sender of a link. There is no need dropping IP packets at receiver with size > configured IP MTU. IP packets with size > receiver L2 MTU will be dropped at sub-IP layer. For this patch: if veth has some notion on L2

Re: [Bridge] [PATCH v2 1/2] net: Added mtu parameter to dev_forward_skb calls

IP MTU and L2 MTU are different animals. IMHO IP MTU is for fragmentation at sender of a link. There is no need dropping IP packets at receiver with size > configured IP MTU. IP packets with size > receiver L2 MTU will be dropped at sub-IP layer. For this patch: if veth has some notion on L2

Re: [PATCH v2 1/2] net: Added mtu parameter to dev_forward_skb calls

On Thu, 11 May 2017 21:10:11 +0200 Fredrik Markström wrote: > On Thu, May 11, 2017 at 6:01 PM, Stephen Hemminger > wrote: > > On Thu, 11 May 2017 15:46:27 +0200 > > Fredrik Markstrom wrote: > > > >> From:

Re: [PATCH v2 1/2] net: Added mtu parameter to dev_forward_skb calls

On Thu, 11 May 2017 21:10:11 +0200 Fredrik Markström wrote: > On Thu, May 11, 2017 at 6:01 PM, Stephen Hemminger > wrote: > > On Thu, 11 May 2017 15:46:27 +0200 > > Fredrik Markstrom wrote: > > > >> From: Fredrik Markström > >> > >> is_skb_forwardable() currently checks if the packet size

Re: [PATCH v2 1/2] net: Added mtu parameter to dev_forward_skb calls

On Thu, May 11, 2017 at 6:01 PM, Stephen Hemminger wrote: > On Thu, 11 May 2017 15:46:27 +0200 > Fredrik Markstrom wrote: > >> From: Fredrik Markström >> >> is_skb_forwardable() currently checks if the packet

Re: [PATCH v2 1/2] net: Added mtu parameter to dev_forward_skb calls

On Thu, May 11, 2017 at 6:01 PM, Stephen Hemminger wrote: > On Thu, 11 May 2017 15:46:27 +0200 > Fredrik Markstrom wrote: > >> From: Fredrik Markström >> >> is_skb_forwardable() currently checks if the packet size is <= mtu of >> the receiving interface. This is not consistent with most of the

Re: [PATCH v2 1/2] net: Added mtu parameter to dev_forward_skb calls

On Thu, 11 May 2017 15:46:27 +0200 Fredrik Markstrom wrote: > From: Fredrik Markström > > is_skb_forwardable() currently checks if the packet size is <= mtu of > the receiving interface. This is not consistent with most of the hardware

Re: [PATCH v2 1/2] net: Added mtu parameter to dev_forward_skb calls

On Thu, 11 May 2017 15:46:27 +0200 Fredrik Markstrom wrote: > From: Fredrik Markström > > is_skb_forwardable() currently checks if the packet size is <= mtu of > the receiving interface. This is not consistent with most of the hardware > ethernet drivers that happily receives packets larger

[PATCH v2 1/2] net: Added mtu parameter to dev_forward_skb calls

From: Fredrik Markström is_skb_forwardable() currently checks if the packet size is <= mtu of the receiving interface. This is not consistent with most of the hardware ethernet drivers that happily receives packets larger then MTU. This patch adds a parameter to

[PATCH v2 1/2] net: Added mtu parameter to dev_forward_skb calls

From: Fredrik Markström is_skb_forwardable() currently checks if the packet size is <= mtu of the receiving interface. This is not consistent with most of the hardware ethernet drivers that happily receives packets larger then MTU. This patch adds a parameter to dev_forward_skb and