Re: [PATCH v2 1/2] perf cs-etm: Set branch instruction flags in packet

2018-12-05 Thread leo . yan
On Wed, Dec 05, 2018 at 10:40:07AM -0700, Mathieu Poirier wrote: [...] > > > > static ocsd_datapath_resp_t cs_etm_decoder__gen_trace_elem_printer( > > > > const void *context, > > > > const ocsd_trc_index_t indx __maybe_unused, > > > > @@

Re: [PATCH v2 1/2] perf cs-etm: Set branch instruction flags in packet

2018-12-05 Thread leo . yan
On Wed, Dec 05, 2018 at 10:40:07AM -0700, Mathieu Poirier wrote: [...] > > > > static ocsd_datapath_resp_t cs_etm_decoder__gen_trace_elem_printer( > > > > const void *context, > > > > const ocsd_trc_index_t indx __maybe_unused, > > > > @@

Re: [PATCH v2 1/2] perf cs-etm: Set branch instruction flags in packet

2018-12-05 Thread Mathieu Poirier
On Tue, 4 Dec 2018 at 23:26, wrote: > > On Mon, Nov 19, 2018 at 03:26:17PM -0700, Mathieu Poirier wrote: > > On Sun, Nov 11, 2018 at 01:07:55PM +0800, Leo Yan wrote: > > > The perf sample data contains flags to indicate the hardware trace data > > > is belonging to which type branch instruction,

Re: [PATCH v2 1/2] perf cs-etm: Set branch instruction flags in packet

2018-12-05 Thread Mathieu Poirier
On Tue, 4 Dec 2018 at 23:26, wrote: > > On Mon, Nov 19, 2018 at 03:26:17PM -0700, Mathieu Poirier wrote: > > On Sun, Nov 11, 2018 at 01:07:55PM +0800, Leo Yan wrote: > > > The perf sample data contains flags to indicate the hardware trace data > > > is belonging to which type branch instruction,

Re: [PATCH v2 1/2] perf cs-etm: Set branch instruction flags in packet

2018-12-04 Thread leo . yan
On Mon, Nov 19, 2018 at 03:26:17PM -0700, Mathieu Poirier wrote: > On Sun, Nov 11, 2018 at 01:07:55PM +0800, Leo Yan wrote: > > The perf sample data contains flags to indicate the hardware trace data > > is belonging to which type branch instruction, thus this can be used to > > print out the

Re: [PATCH v2 1/2] perf cs-etm: Set branch instruction flags in packet

2018-12-04 Thread leo . yan
On Mon, Nov 19, 2018 at 03:26:17PM -0700, Mathieu Poirier wrote: > On Sun, Nov 11, 2018 at 01:07:55PM +0800, Leo Yan wrote: > > The perf sample data contains flags to indicate the hardware trace data > > is belonging to which type branch instruction, thus this can be used to > > print out the

Re: [PATCH v2 1/2] perf cs-etm: Set branch instruction flags in packet

2018-11-19 Thread Mathieu Poirier
On Sun, Nov 11, 2018 at 01:07:55PM +0800, Leo Yan wrote: > The perf sample data contains flags to indicate the hardware trace data > is belonging to which type branch instruction, thus this can be used to > print out the human readable string. Arm CoreSight ETM sample data is > missed to set

Re: [PATCH v2 1/2] perf cs-etm: Set branch instruction flags in packet

2018-11-19 Thread Mathieu Poirier
On Sun, Nov 11, 2018 at 01:07:55PM +0800, Leo Yan wrote: > The perf sample data contains flags to indicate the hardware trace data > is belonging to which type branch instruction, thus this can be used to > print out the human readable string. Arm CoreSight ETM sample data is > missed to set

[PATCH v2 1/2] perf cs-etm: Set branch instruction flags in packet

2018-11-10 Thread Leo Yan
The perf sample data contains flags to indicate the hardware trace data is belonging to which type branch instruction, thus this can be used to print out the human readable string. Arm CoreSight ETM sample data is missed to set flags and it is always set to zeros, this results in perf tool skips

[PATCH v2 1/2] perf cs-etm: Set branch instruction flags in packet

2018-11-10 Thread Leo Yan
The perf sample data contains flags to indicate the hardware trace data is belonging to which type branch instruction, thus this can be used to print out the human readable string. Arm CoreSight ETM sample data is missed to set flags and it is always set to zeros, this results in perf tool skips