Re: [PATCH v2 1/2] pinctrl: single: check for any error when getting rows

2016-11-11 Thread Linus Walleij
On Wed, Nov 9, 2016 at 3:54 PM, Axel Haslam wrote: > pinctrl_count_index_with_args returns -ENOENT not > -EINVAL. The return check would pass, and we would > try to kzalloc with a negative error size throwing > a warning. > > Instead of checking for -EINVAL specifically, lets > check for any erro

[PATCH v2 1/2] pinctrl: single: check for any error when getting rows

2016-11-09 Thread Axel Haslam
pinctrl_count_index_with_args returns -ENOENT not -EINVAL. The return check would pass, and we would try to kzalloc with a negative error size throwing a warning. Instead of checking for -EINVAL specifically, lets check for any error and avoid negative size allocations. Signed-off-by: Axel Haslam