On Wed, 2021-02-10 at 13:21 -0800, Drew Fustini wrote:
> I will change from the incorrect 0400 to 0444.
Thanks.
> As for S_IFREG, it does seem like leaving off S_IFREG is the most common
> case when using octal permissions with debugfs_create_*():
>
> $ git grep debugfs_create drivers/ |grep
On Wed, Feb 10, 2021 at 04:36:00AM -0800, Joe Perches wrote:
> On Wed, 2021-02-10 at 12:18 +0200, Andy Shevchenko wrote:
> > On Wed, Feb 10, 2021 at 10:30 AM Joe Perches wrote:
> > > On Tue, 2021-02-09 at 23:49 -0800, Drew Fustini wrote:
> >
> > > > - debugfs_create_file("pinctrl-devices",
On Wed, 2021-02-10 at 12:18 +0200, Andy Shevchenko wrote:
> On Wed, Feb 10, 2021 at 10:30 AM Joe Perches wrote:
> > On Tue, 2021-02-09 at 23:49 -0800, Drew Fustini wrote:
>
> > > - debugfs_create_file("pinctrl-devices", S_IFREG | S_IRUGO,
> > > + debugfs_create_file("pinctrl-devices",
On Wed, Feb 10, 2021 at 10:30 AM Joe Perches wrote:
> On Tue, 2021-02-09 at 23:49 -0800, Drew Fustini wrote:
> > - debugfs_create_file("pinctrl-devices", S_IFREG | S_IRUGO,
> > + debugfs_create_file("pinctrl-devices", 0400,
> > debugfs_root, NULL,
On Wed, Feb 10, 2021 at 9:50 AM Drew Fustini wrote:
>
> Switch over pinctrl debugfs files to use octal permissions as they are
> preferred over symbolic permissions. Refer to commit f90774e1fd27
> ("checkpatch: look for symbolic permissions and suggest octal instead").
You forgot:
Suggested-by:
On Wed, Feb 10, 2021 at 10:31 AM Geert Uytterhoeven
wrote:
> On Wed, Feb 10, 2021 at 8:50 AM Drew Fustini wrote:
...
> > - debugfs_create_file("pinctrl-devices", S_IFREG | S_IRUGO,
> > + debugfs_create_file("pinctrl-devices", 0400,
>
> What about the loss of S_IFREG?
What do you
Hi Drew,
On Wed, Feb 10, 2021 at 8:50 AM Drew Fustini wrote:
> Switch over pinctrl debugfs files to use octal permissions as they are
> preferred over symbolic permissions. Refer to commit f90774e1fd27
> ("checkpatch: look for symbolic permissions and suggest octal instead").
>
> Signed-off-by:
On Tue, 2021-02-09 at 23:49 -0800, Drew Fustini wrote:
> Switch over pinctrl debugfs files to use octal permissions as they are
> preferred over symbolic permissions. Refer to commit f90774e1fd27
> ("checkpatch: look for symbolic permissions and suggest octal instead").
>
> Signed-off-by: Drew
Switch over pinctrl debugfs files to use octal permissions as they are
preferred over symbolic permissions. Refer to commit f90774e1fd27
("checkpatch: look for symbolic permissions and suggest octal instead").
Signed-off-by: Drew Fustini
---
drivers/pinctrl/core.c| 6 +++---
9 matches
Mail list logo
