Re: [PATCH v2 1/2] sched/fair: Cleanup load_balance() condition

2018-10-30 Thread Peter Zijlstra
On Tue, Oct 30, 2018 at 10:27:59AM +, Valentin Schneider wrote: > Hi, > > On 26/09/2018 16:12, Valentin Schneider wrote: > > The alignment of the condition is off, clean that up. > > > > Also, logical operators have lower precedence than bitwise/relational > > operators, so remove one layer o

Re: [PATCH v2 1/2] sched/fair: Cleanup load_balance() condition

2018-10-30 Thread Valentin Schneider
Hi, On 26/09/2018 16:12, Valentin Schneider wrote: > The alignment of the condition is off, clean that up. > > Also, logical operators have lower precedence than bitwise/relational > operators, so remove one layer of parentheses to make the condition a > bit simpler to follow. > > Signed-off-by:

[PATCH v2 1/2] sched/fair: Cleanup load_balance() condition

2018-09-26 Thread Valentin Schneider
The alignment of the condition is off, clean that up. Also, logical operators have lower precedence than bitwise/relational operators, so remove one layer of parentheses to make the condition a bit simpler to follow. Signed-off-by: Valentin Schneider --- kernel/sched/fair.c | 6 +++--- 1 file c