Re: [PATCH v2 1/2] scsi: hisi_sas: Remove unnecessary devm_kfree

2021-01-12 Thread Bean Huo
On Tue, 2021-01-12 at 09:03 +, John Garry wrote: > On 11/01/2021 23:10, Bean Huo wrote: > > From: Bean Huo > > > > The memory allocated with devm_kzalloc() is freed automatically > > no need to explicitly call devm_kfree. > > > > This change is not right - we use devm_kfree() to manually re

Re: [PATCH v2 1/2] scsi: hisi_sas: Remove unnecessary devm_kfree

2021-01-12 Thread John Garry
On 11/01/2021 23:10, Bean Huo wrote: From: Bean Huo The memory allocated with devm_kzalloc() is freed automatically no need to explicitly call devm_kfree. This change is not right - we use devm_kfree() to manually release the devm-allocated debugfs memories upon memory allocation failure fo

[PATCH v2 1/2] scsi: hisi_sas: Remove unnecessary devm_kfree

2021-01-11 Thread Bean Huo
From: Bean Huo The memory allocated with devm_kzalloc() is freed automatically no need to explicitly call devm_kfree. Signed-off-by: Bean Huo --- drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 28 +- 1 file changed, 1 insertion(+), 27 deletions(-) diff --git a/drivers/scsi/h