On 2020-11-26 03:02, Bean Huo wrote:
On Wed, 2020-11-25 at 20:28 +0800, Can Guo wrote:
> On Wed, 2020-11-25 at 08:53 +0800, Can Guo wrote:
> > > > + bool always_on_while_link_active;
> > >
> > > Can,
> > > using a sentence as a parameter name looks a little bit clumsy
> > > to
> > > me.
>
On 2020-11-26 08:58, Stanley Chu wrote:
Hi Can,
"Refector" in title shall be "Refactor"?
On Mon, 2020-11-23 at 23:28 -0800, Can Guo wrote:
Remove the param skip_ref_clk from __ufshcd_setup_clocks(), but keep a
flag
in struct ufs_clk_info to tell whether a clock can be disabled or not
while
t
Hi Can,
"Refector" in title shall be "Refactor"?
On Mon, 2020-11-23 at 23:28 -0800, Can Guo wrote:
> Remove the param skip_ref_clk from __ufshcd_setup_clocks(), but keep a flag
> in struct ufs_clk_info to tell whether a clock can be disabled or not while
> the link is active.
>
> Signed-off-by:
On Wed, 2020-11-25 at 20:28 +0800, Can Guo wrote:
> > On Wed, 2020-11-25 at 08:53 +0800, Can Guo wrote:
> > > > > + bool always_on_while_link_active;
> > > >
> > > > Can,
> > > > using a sentence as a parameter name looks a little bit clumsy
> > > > to
> > > > me.
> > > > The meaning has bee
On 2020-11-25 19:54, Bean Huo wrote:
On Wed, 2020-11-25 at 08:53 +0800, Can Guo wrote:
> > + bool always_on_while_link_active;
>
> Can,
> using a sentence as a parameter name looks a little bit clumsy to
> me.
> The meaning has been explained in the comments section. How about
> simplify i
On Wed, 2020-11-25 at 08:53 +0800, Can Guo wrote:
> > > + bool always_on_while_link_active;
> >
> > Can,
> > using a sentence as a parameter name looks a little bit clumsy to
> > me.
> > The meaning has been explained in the comments section. How about
> > simplify it and in line with other
On 2020-11-25 08:53, Can Guo wrote:
On 2020-11-25 05:09, Bean Huo wrote:
On Mon, 2020-11-23 at 23:28 -0800, Can Guo wrote:
+++ b/drivers/scsi/ufs/ufshcd.h
@@ -229,6 +229,8 @@ struct ufs_dev_cmd {
* @max_freq: maximum frequency supported by the clock
* @min_freq: min frequency that can be us
On 2020-11-25 05:09, Bean Huo wrote:
On Mon, 2020-11-23 at 23:28 -0800, Can Guo wrote:
+++ b/drivers/scsi/ufs/ufshcd.h
@@ -229,6 +229,8 @@ struct ufs_dev_cmd {
* @max_freq: maximum frequency supported by the clock
* @min_freq: min frequency that can be used for clock scaling
* @curr_freq:
On Mon, 2020-11-23 at 23:28 -0800, Can Guo wrote:
> +++ b/drivers/scsi/ufs/ufshcd.h
> @@ -229,6 +229,8 @@ struct ufs_dev_cmd {
> * @max_freq: maximum frequency supported by the clock
> * @min_freq: min frequency that can be used for clock scaling
> * @curr_freq: indicates the current frequenc
Remove the param skip_ref_clk from __ufshcd_setup_clocks(), but keep a flag
in struct ufs_clk_info to tell whether a clock can be disabled or not while
the link is active.
Signed-off-by: Can Guo
---
drivers/scsi/ufs/ufshcd-pltfrm.c | 2 ++
drivers/scsi/ufs/ufshcd.c| 25 +
10 matches
Mail list logo
