Re: [PATCH v2 1/2] soc: qcom: geni: Don't ignore clk_round_rate() errors in geni_se_clk_tbl_get()

On Thu, Sep 06, 2018 at 03:39:04PM -0700, Doug Anderson wrote: > Hi > > On Thu, Sep 6, 2018 at 3:35 PM, kbuild test robot wrote: > > Hi Douglas, > > > > Thank you for the patch! Perhaps something to improve: > > > > [auto build test WARNING on agross/for-next] > > [also build test WARNING on v4.1

Re: [PATCH v2 1/2] soc: qcom: geni: Don't ignore clk_round_rate() errors in geni_se_clk_tbl_get()

Hi On Thu, Sep 6, 2018 at 3:35 PM, kbuild test robot wrote: > Hi Douglas, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on agross/for-next] > [also build test WARNING on v4.19-rc2 next-20180906] > [if your patch is applied to the wrong git tree, please dr

Re: [PATCH v2 1/2] soc: qcom: geni: Don't ignore clk_round_rate() errors in geni_se_clk_tbl_get()

Hi Douglas, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on agross/for-next] [also build test WARNING on v4.19-rc2 next-20180906] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0da

[PATCH v2 1/2] soc: qcom: geni: Don't ignore clk_round_rate() errors in geni_se_clk_tbl_get()

The function clk_round_rate() is defined to return a "long", not an "unsigned long". That's because it might return a negative error code. Change the call in geni_se_clk_tbl_get() to check for errors. While we're at it, get rid of a useless init of "freq". NOTE: overall the idea that we should