Re: [PATCH v2 1/2] spi: Add the SPI daisy chain support.

2020-07-07 Thread Mark Brown
On Tue, Jul 07, 2020 at 12:53:38PM +0200, Adrian Fiergolski wrote: > On 06.07.2020 18:18, Mark Brown wrote: > > On Mon, Jul 06, 2020 at 11:22:43AM +0200, Adrian Fiergolski wrote: > > this. Perhaps this needs to be a library for devices that can daisy > > chain? It does feel like the instances sh

Re: [PATCH v2 1/2] spi: Add the SPI daisy chain support.

2020-07-07 Thread Adrian Fiergolski
On 07.07.2020 12:25, Mark Brown wrote: > On Mon, Jul 06, 2020 at 09:57:53PM +0200, Geert Uytterhoeven wrote: >> On Mon, Jul 6, 2020 at 6:18 PM Mark Brown wrote: >>> It would really help to have an example of how a client device will use >>> this, right now it's a bit hard to follow. Overall it

Re: [PATCH v2 1/2] spi: Add the SPI daisy chain support.

2020-07-07 Thread Adrian Fiergolski
On 06.07.2020 18:18, Mark Brown wrote: > On Mon, Jul 06, 2020 at 11:22:43AM +0200, Adrian Fiergolski wrote: > > Please don't send new patches in reply to old threads, it buries them > and can be confusing. Ok, thanks. It's my debut in sharing a complete driver patch ;-) > >> The implementation

Re: [PATCH v2 1/2] spi: Add the SPI daisy chain support.

2020-07-07 Thread Mark Brown
On Mon, Jul 06, 2020 at 09:57:53PM +0200, Geert Uytterhoeven wrote: > On Mon, Jul 6, 2020 at 6:18 PM Mark Brown wrote: > > It would really help to have an example of how a client device will use > > this, right now it's a bit hard to follow. Overall it feels like this > > should be better abstra

Re: [PATCH v2 1/2] spi: Add the SPI daisy chain support.

2020-07-06 Thread Geert Uytterhoeven
Hi Adrian, On Mon, Jul 6, 2020 at 6:18 PM Mark Brown wrote: > On Mon, Jul 06, 2020 at 11:22:43AM +0200, Adrian Fiergolski wrote: > > The implementation is transparent for the SPI devices and doesn't require > > their modifications. It is based on a virtual SPI device (spi-daisy_chain) > > and def

Re: [PATCH v2 1/2] spi: Add the SPI daisy chain support.

2020-07-06 Thread Mark Brown
On Mon, Jul 06, 2020 at 11:22:43AM +0200, Adrian Fiergolski wrote: Please don't send new patches in reply to old threads, it buries them and can be confusing. > The implementation is transparent for the SPI devices and doesn't require > their modifications. It is based on a virtual SPI device (sp

[PATCH v2 1/2] spi: Add the SPI daisy chain support.

2020-07-06 Thread Adrian Fiergolski
The implementation is transparent for the SPI devices and doesn't require their modifications. It is based on a virtual SPI device (spi-daisy_chain) and defines two required device tree properties ('spi-daisy-chain-len' and 'spi-daisy-chain-noop') and one optional ('spi-daisy-chain-bits_per_word').