Re: [PATCH v2 1/2] staging: iio: frequency: ad9834: Move frequency to standard iio types

2019-03-03 Thread Jonathan Cameron
On Fri, 22 Feb 2019 13:10:26 + "Bia, Beniamin" wrote: > Thank you for taking some time reviewing my code. > Ad9833/ad9834 has two frequency and phase registers and only one > output. The user can select which register is selected as input with a > mux.Because I wanted to reduce as much as

Re: [PATCH v2 1/2] staging: iio: frequency: ad9834: Move frequency to standard iio types

2019-02-22 Thread Bia, Beniamin
Thank you for taking some time reviewing my code. Ad9833/ad9834 has two frequency and phase registers and only one output. The user can select which register is selected as input with a mux.Because I wanted to reduce as much as possible the custom attributes, I mapped the frequency 0 from register

Re: [PATCH v2 1/2] staging: iio: frequency: ad9834: Move frequency to standard iio types

2019-02-20 Thread Jonathan Cameron
On Thu, 14 Feb 2019 18:41:29 +0200 Beniamin Bia wrote: > Frequency attribute is added with a standard type from iio framework > instead of custom attribute. This is a small step towards removing any > unnecessary custom attribute. Ad9834 will diverge from ad9833 in the > future, that is why we

[PATCH v2 1/2] staging: iio: frequency: ad9834: Move frequency to standard iio types

2019-02-14 Thread Beniamin Bia
Frequency attribute is added with a standard type from iio framework instead of custom attribute. This is a small step towards removing any unnecessary custom attribute. Ad9834 will diverge from ad9833 in the future, that is why we have two identical arrays for ad9834 and 9833. Signed-off-by: