Re: [PATCH v2 1/2] watchdog: dw: RMW the control register

2018-03-09 Thread Guenter Roeck
On 03/09/2018 07:46 PM, Brian Norris wrote: RK3399 has rst_pulse_length in CONTROL_REG[4:2], determining the length of pulse to issue for system reset. We shouldn't clobber this value, because that might make the system reset ineffective. On RK3399, we're seeing that a value of 000b (meaning 2

Re: [PATCH v2 1/2] watchdog: dw: RMW the control register

2018-03-09 Thread Guenter Roeck
On 03/09/2018 07:46 PM, Brian Norris wrote: RK3399 has rst_pulse_length in CONTROL_REG[4:2], determining the length of pulse to issue for system reset. We shouldn't clobber this value, because that might make the system reset ineffective. On RK3399, we're seeing that a value of 000b (meaning 2

[PATCH v2 1/2] watchdog: dw: RMW the control register

2018-03-09 Thread Brian Norris
RK3399 has rst_pulse_length in CONTROL_REG[4:2], determining the length of pulse to issue for system reset. We shouldn't clobber this value, because that might make the system reset ineffective. On RK3399, we're seeing that a value of 000b (meaning 2 cycles) yields an unreliable (partial?) reset,

[PATCH v2 1/2] watchdog: dw: RMW the control register

2018-03-09 Thread Brian Norris
RK3399 has rst_pulse_length in CONTROL_REG[4:2], determining the length of pulse to issue for system reset. We shouldn't clobber this value, because that might make the system reset ineffective. On RK3399, we're seeing that a value of 000b (meaning 2 cycles) yields an unreliable (partial?) reset,