Re: [PATCH v2 1/3] ASoC: es8316: judge PCM rate at later timing

2019-09-03 Thread Katsuhiro Suzuki
Hello Mark, On 2019/09/03 20:11, Mark Brown wrote: On Tue, Sep 03, 2019 at 04:19:10AM +0900, Katsuhiro Suzuki wrote: On 2019/09/02 21:02, Mark Brown wrote: The best way to handle this is to try to support both fixed and variable clock rates, some other drivers do this by setting constraints

Re: [PATCH v2 1/3] ASoC: es8316: judge PCM rate at later timing

2019-09-03 Thread Mark Brown
On Tue, Sep 03, 2019 at 04:19:10AM +0900, Katsuhiro Suzuki wrote: > On 2019/09/02 21:02, Mark Brown wrote: > > The best way to handle this is to try to support both fixed and variable > > clock rates, some other drivers do this by setting constraints based on > > MCLK only if the MCLK has been set

Re: [PATCH v2 1/3] ASoC: es8316: judge PCM rate at later timing

2019-09-02 Thread Katsuhiro Suzuki
Hello Mark, Thanks a lot for your comments. On 2019/09/02 21:02, Mark Brown wrote: On Sun, Sep 01, 2019 at 01:26:48AM +0900, Katsuhiro Suzuki wrote: This patch change the judge timing about playing/capturing PCM rate. Original code set constraints list of PCM rate limits at set_sysclk. This s

Re: [PATCH v2 1/3] ASoC: es8316: judge PCM rate at later timing

2019-09-02 Thread Mark Brown
On Sun, Sep 01, 2019 at 01:26:48AM +0900, Katsuhiro Suzuki wrote: > This patch change the judge timing about playing/capturing PCM rate. > > Original code set constraints list of PCM rate limits at set_sysclk. > This strategy works well if system is using fixed rate clock. > > But some boards and

[PATCH v2 1/3] ASoC: es8316: judge PCM rate at later timing

2019-08-31 Thread Katsuhiro Suzuki
This patch change the judge timing about playing/capturing PCM rate. Original code set constraints list of PCM rate limits at set_sysclk. This strategy works well if system is using fixed rate clock. But some boards and SoC (such as RockPro64 and RockChip I2S) has connected SoC MCLK out to ES8316