Re: [PATCH v2 1/3] HID: Use hid_parser for pre-scanning the report descriptors

2013-08-22 Thread Benjamin Tissoires
Hi Henrik, On Wed, Aug 21, 2013 at 8:15 PM, Henrik Rydberg wrote: > Hi Benjamin, > > this looks pretty good to me, just a few nitpicks below. > >> hid_scan_report() implements its own HID report descriptor parsing. It is >> going to be really bad with the detection of Win 8 certified

Re: [PATCH v2 1/3] HID: Use hid_parser for pre-scanning the report descriptors

2013-08-22 Thread Benjamin Tissoires
Hi Henrik, On Wed, Aug 21, 2013 at 8:15 PM, Henrik Rydberg rydb...@euromail.se wrote: Hi Benjamin, this looks pretty good to me, just a few nitpicks below. hid_scan_report() implements its own HID report descriptor parsing. It is going to be really bad with the detection of Win 8 certified

Re: [PATCH v2 1/3] HID: Use hid_parser for pre-scanning the report descriptors

2013-08-21 Thread Henrik Rydberg
Hi Benjamin, this looks pretty good to me, just a few nitpicks below. > hid_scan_report() implements its own HID report descriptor parsing. It is > going to be really bad with the detection of Win 8 certified touchscreen, > as this detection relies on a special feature and on the report_size and

[PATCH v2 1/3] HID: Use hid_parser for pre-scanning the report descriptors

2013-08-21 Thread Benjamin Tissoires
hid_scan_report() implements its own HID report descriptor parsing. It is going to be really bad with the detection of Win 8 certified touchscreen, as this detection relies on a special feature and on the report_size and report_count fields. We can use the existing HID parser in hid-core for

[PATCH v2 1/3] HID: Use hid_parser for pre-scanning the report descriptors

2013-08-21 Thread Benjamin Tissoires
hid_scan_report() implements its own HID report descriptor parsing. It is going to be really bad with the detection of Win 8 certified touchscreen, as this detection relies on a special feature and on the report_size and report_count fields. We can use the existing HID parser in hid-core for

Re: [PATCH v2 1/3] HID: Use hid_parser for pre-scanning the report descriptors

2013-08-21 Thread Henrik Rydberg
Hi Benjamin, this looks pretty good to me, just a few nitpicks below. hid_scan_report() implements its own HID report descriptor parsing. It is going to be really bad with the detection of Win 8 certified touchscreen, as this detection relies on a special feature and on the report_size and