Re: [PATCH v2 1/3] Revert "perf session: Fix decompression of PERF_RECORD_COMPRESSED records"

2020-12-02 Thread Alexei Budankov
Hi Alexey. Please see below. On 02.12.2020 17:04, Bayduraev, Alexey V wrote: > Hi, > > I was able to reproduce "Couldn't allocate memory for decompression" on > 32-bit > perf with long perf.data. > > On my side mmap() in perf_session__process_compressed_event() fails with > ENOMEM, > due to

Re: [PATCH v2 1/3] Revert "perf session: Fix decompression of PERF_RECORD_COMPRESSED records"

2020-12-02 Thread Bayduraev, Alexey V
Hi, I was able to reproduce "Couldn't allocate memory for decompression" on 32-bit perf with long perf.data. On my side mmap() in perf_session__process_compressed_event() fails with ENOMEM, due to exceeded memory limit for 32-bit applications. This happens with or without Petr's patch. As I can

Re: [PATCH v2 1/3] Revert "perf session: Fix decompression of PERF_RECORD_COMPRESSED records"

2020-12-01 Thread Alexei Budankov
Eventually sending to the proper Alexey's address. On 02.12.2020 0:04, Alexei Budankov wrote: > > On 01.12.2020 22:09, Jiri Olsa wrote: >> On Mon, Nov 30, 2020 at 12:40:20PM +0100, Petr Malat wrote: >>> Hi Jiří, >>> were you able to reproduce the issue? I may also upload perf-archive >>> if tha

Re: [PATCH v2 1/3] Revert "perf session: Fix decompression of PERF_RECORD_COMPRESSED records"

2020-12-01 Thread Alexei Budankov
On 01.12.2020 22:09, Jiri Olsa wrote: > On Mon, Nov 30, 2020 at 12:40:20PM +0100, Petr Malat wrote: >> Hi Jiří, >> were you able to reproduce the issue? I may also upload perf-archive >> if that would help. > > oh yea ;-) seems like those 2 commits you reverted broke 32 bits > perf for data file

Re: [PATCH v2 1/3] Revert "perf session: Fix decompression of PERF_RECORD_COMPRESSED records"

2020-12-01 Thread Jiri Olsa
On Mon, Nov 30, 2020 at 12:40:20PM +0100, Petr Malat wrote: > Hi Jiří, > were you able to reproduce the issue? I may also upload perf-archive > if that would help. oh yea ;-) seems like those 2 commits you reverted broke 32 bits perf for data files > 32MB but the fix you did does not work for Ale

Re: [PATCH v2 1/3] Revert "perf session: Fix decompression of PERF_RECORD_COMPRESSED records"

2020-11-30 Thread Petr Malat
Hi Jiří, were you able to reproduce the issue? I may also upload perf-archive if that would help. Petr On Tue, Nov 24, 2020 at 07:15:19PM +0100, Petr Malat wrote: > Hi! > On Tue, Nov 24, 2020 at 03:36:45PM +0100, Jiri Olsa wrote: > > On Tue, Nov 24, 2020 at 11:29:15AM +0100, Petr Malat wrote: >

Re: [PATCH v2 1/3] Revert "perf session: Fix decompression of PERF_RECORD_COMPRESSED records"

2020-11-24 Thread Petr Malat
Hi! On Tue, Nov 24, 2020 at 03:36:45PM +0100, Jiri Olsa wrote: > On Tue, Nov 24, 2020 at 11:29:15AM +0100, Petr Malat wrote: > > Both mmapped and compressed events can be split by the buffer boundary, > > it doesn't make sense to handle them differently. > I'm going to need more than this, if there

Re: [PATCH v2 1/3] Revert "perf session: Fix decompression of PERF_RECORD_COMPRESSED records"

2020-11-24 Thread Jiri Olsa
On Tue, Nov 24, 2020 at 11:29:15AM +0100, Petr Malat wrote: > Both mmapped and compressed events can be split by the buffer boundary, > it doesn't make sense to handle them differently. hi, I'm going to need more than this, if there's a problem with current code please share more details, what's b

[PATCH v2 1/3] Revert "perf session: Fix decompression of PERF_RECORD_COMPRESSED records"

2020-11-24 Thread Petr Malat
Both mmapped and compressed events can be split by the buffer boundary, it doesn't make sense to handle them differently. Fixes: bb1835a3b86c ("perf session: Fix decompression of PERF_RECORD_COMPRESSED records") Fixes: 57fc032ad643 ("perf session: Avoid infinite loop when seeing invalid header.s