Re: [PATCH v2 1/3] dmaengine: Add support for APM X-Gene SoC DMA engine driver

2015-01-14 Thread Arnd Bergmann
On Wednesday 14 January 2015 14:56:33 Rameshwar Sahu wrote: > > > Also add the correct dma-ranges property in the parent, or else this will > > fail in the future once we add proper checks to dma_set_mask. > > I see arch/arm64 kernel doesn't use dma range value parsed from > dma-range property

Re: [PATCH v2 1/3] dmaengine: Add support for APM X-Gene SoC DMA engine driver

2015-01-14 Thread Rameshwar Sahu
Hi Arnd, Thanks, with regards, Ram On Tue, Jan 13, 2015 at 12:25 AM, Arnd Bergmann wrote: > On Monday 12 January 2015 14:40:09 Rameshwar Sahu wrote: >> > + >> > + dma_set_mask_and_coherent(>dev, >> > + (sizeof(dma_addr_t) == sizeof(u64)) ? >> > +

Re: [PATCH v2 1/3] dmaengine: Add support for APM X-Gene SoC DMA engine driver

2015-01-14 Thread Rameshwar Sahu
Hi Arnd, Thanks, with regards, Ram On Tue, Jan 13, 2015 at 12:25 AM, Arnd Bergmann a...@arndb.de wrote: On Monday 12 January 2015 14:40:09 Rameshwar Sahu wrote: + + dma_set_mask_and_coherent(pdev-dev, + (sizeof(dma_addr_t) == sizeof(u64)) ? +

Re: [PATCH v2 1/3] dmaengine: Add support for APM X-Gene SoC DMA engine driver

2015-01-14 Thread Arnd Bergmann
On Wednesday 14 January 2015 14:56:33 Rameshwar Sahu wrote: Also add the correct dma-ranges property in the parent, or else this will fail in the future once we add proper checks to dma_set_mask. I see arch/arm64 kernel doesn't use dma range value parsed from dma-range property

Re: [PATCH v2 1/3] dmaengine: Add support for APM X-Gene SoC DMA engine driver

2015-01-12 Thread Arnd Bergmann
On Monday 12 January 2015 14:40:09 Rameshwar Sahu wrote: > > + > > + dma_set_mask_and_coherent(>dev, > > + (sizeof(dma_addr_t) == sizeof(u64)) ? > > + DMA_BIT_MASK(64) : DMA_BIT_MASK(32)); > > + > I commented on this on v1

Re: [PATCH v2 1/3] dmaengine: Add support for APM X-Gene SoC DMA engine driver

2015-01-12 Thread Rameshwar Sahu
Hi All, Any comments on this patch ?? Thanks, with regards, Ram On Wed, Jan 7, 2015 at 4:39 PM, Rameshwar Prasad Sahu wrote: > This patch implements the APM X-Gene SoC DMA engine driver. The APM X-Gene > SoC DMA engine consists of 4 DMA channels for performing DMA operations. > These DMA

Re: [PATCH v2 1/3] dmaengine: Add support for APM X-Gene SoC DMA engine driver

2015-01-12 Thread Rameshwar Sahu
Hi All, Any comments on this patch ?? Thanks, with regards, Ram On Wed, Jan 7, 2015 at 4:39 PM, Rameshwar Prasad Sahu rs...@apm.com wrote: This patch implements the APM X-Gene SoC DMA engine driver. The APM X-Gene SoC DMA engine consists of 4 DMA channels for performing DMA operations. These

Re: [PATCH v2 1/3] dmaengine: Add support for APM X-Gene SoC DMA engine driver

2015-01-12 Thread Arnd Bergmann
On Monday 12 January 2015 14:40:09 Rameshwar Sahu wrote: + + dma_set_mask_and_coherent(pdev-dev, + (sizeof(dma_addr_t) == sizeof(u64)) ? + DMA_BIT_MASK(64) : DMA_BIT_MASK(32)); + I commented on this on v1 already:

[PATCH v2 1/3] dmaengine: Add support for APM X-Gene SoC DMA engine driver

2015-01-07 Thread Rameshwar Prasad Sahu
This patch implements the APM X-Gene SoC DMA engine driver. The APM X-Gene SoC DMA engine consists of 4 DMA channels for performing DMA operations. These DMA operations include memory copy and scatter gathering offload. Signed-off-by: Rameshwar Prasad Sahu Signed-off-by: Loc Ho ---

[PATCH v2 1/3] dmaengine: Add support for APM X-Gene SoC DMA engine driver

2015-01-07 Thread Rameshwar Prasad Sahu
This patch implements the APM X-Gene SoC DMA engine driver. The APM X-Gene SoC DMA engine consists of 4 DMA channels for performing DMA operations. These DMA operations include memory copy and scatter gathering offload. Signed-off-by: Rameshwar Prasad Sahu rs...@apm.com Signed-off-by: Loc Ho