Re: [PATCH v2 1/3] driver core: add probe_err log helper

2018-10-17 Thread Greg Kroah-Hartman
On Wed, Oct 17, 2018 at 10:58:24AM +0200, Andrzej Hajda wrote: > During probe every time driver gets resource it should usually check for error > printk some message if it is not -EPROBE_DEFER and return the error. This > pattern is simple but requires adding few lines after any resource acquisitio

Re: [PATCH v2 1/3] driver core: add probe_err log helper

2018-10-17 Thread Andy Shevchenko
On Wed, Oct 17, 2018 at 11:58 AM Andrzej Hajda wrote: > > During probe every time driver gets resource it should usually check for error > printk some message if it is not -EPROBE_DEFER and return the error. This > pattern is simple but requires adding few lines after any resource acquisition > co

Re: [PATCH v2 1/3] driver core: add probe_err log helper

2018-10-17 Thread Mark Brown
On Wed, Oct 17, 2018 at 10:58:24AM +0200, Andrzej Hajda wrote: > During probe every time driver gets resource it should usually check for error > printk some message if it is not -EPROBE_DEFER and return the error. This > pattern is simple but requires adding few lines after any resource acquisitio

[PATCH v2 1/3] driver core: add probe_err log helper

2018-10-17 Thread Andrzej Hajda
During probe every time driver gets resource it should usually check for error printk some message if it is not -EPROBE_DEFER and return the error. This pattern is simple but requires adding few lines after any resource acquisition code, as a result it is often omited or implemented only partially.