Re: [PATCH v2 1/3] i2c: cadence: Handle > 252 byte transfers

2014-12-05 Thread Michal Simek
On 12/05/2014 06:41 AM, rajeev kumar wrote: > On Wed, Dec 3, 2014 at 6:05 PM, Harini Katakam wrote: >> The I2C controller sends a NACK to the slave when transfer size register >> reaches zero, irrespective of the hold bit. So, in order to handle transfers >> greater than 252 bytes, the transfer si

Re: [PATCH v2 1/3] i2c: cadence: Handle > 252 byte transfers

2014-12-04 Thread Harini Katakam
Hi, On Fri, Dec 5, 2014 at 11:11 AM, rajeev kumar wrote: > On Wed, Dec 3, 2014 at 6:05 PM, Harini Katakam wrote: >> The I2C controller sends a NACK to the slave when transfer size register >> reaches zero, irrespective of the hold bit. So, in order to handle transfers >> greater than 252 bytes,

Re: [PATCH v2 1/3] i2c: cadence: Handle > 252 byte transfers

2014-12-04 Thread rajeev kumar
On Wed, Dec 3, 2014 at 6:05 PM, Harini Katakam wrote: > The I2C controller sends a NACK to the slave when transfer size register > reaches zero, irrespective of the hold bit. So, in order to handle transfers > greater than 252 bytes, the transfer size register has to be maintained at a > value >=

Re: [PATCH v2 1/3] i2c: cadence: Handle > 252 byte transfers

2014-12-04 Thread Harini Katakam
Hi, On Fri, Dec 5, 2014 at 12:02 AM, Wolfram Sang wrote: > >> + /* >> + * If the device is sending data If there is further >> + * data to be sent. Calculate the available space >> + * in FIFO and fill the FIFO with that many bytes. >> +

Re: [PATCH v2 1/3] i2c: cadence: Handle > 252 byte transfers

2014-12-04 Thread Wolfram Sang
> + /* > + * If the device is sending data If there is further > + * data to be sent. Calculate the available space > + * in FIFO and fill the FIFO with that many bytes. > + */ This comment looks broken. In general, I think there sho

[PATCH v2 1/3] i2c: cadence: Handle > 252 byte transfers

2014-12-03 Thread Harini Katakam
The I2C controller sends a NACK to the slave when transfer size register reaches zero, irrespective of the hold bit. So, in order to handle transfers greater than 252 bytes, the transfer size register has to be maintained at a value >= 1. This patch implements the same. The interrupt status is clea