Re: [PATCH v2 1/3] leds: add device activity LED triggers

2015-10-02 Thread Maciek Borzecki
On 10/02 12:08, Josh Cartwright wrote: > > Hmm, maybe we're bikeshedding at this point, but LEDs with those names > seem much more straightfoward to me than a "dev-:" name, for > devices which have done dynamic dev_t allocation. > > > Also, if I'm not mistaken, using this approach the partitions o

Re: [PATCH v2 1/3] leds: add device activity LED triggers

2015-10-02 Thread Josh Cartwright
On Fri, Oct 02, 2015 at 09:45:37AM +0200, Maciek Borzecki wrote: > On 10/01 09:47, Josh Cartwright wrote: > > On Thu, Oct 01, 2015 at 04:04:31PM +0200, Maciek Borzecki wrote: > > > The patch adds LED triggers for indicating an activity on a selected > > > device. The drivers that intend to use trig

Re: [PATCH v2 1/3] leds: add device activity LED triggers

2015-10-02 Thread Maciek Borzecki
On 10/01 09:47, Josh Cartwright wrote: > Hello Maciek- > > Some architectural questions below: > > On Thu, Oct 01, 2015 at 04:04:31PM +0200, Maciek Borzecki wrote: > > The patch adds LED triggers for indicating an activity on a selected > > device. The drivers that intend to use triggers need to re

Re: [PATCH v2 1/3] leds: add device activity LED triggers

2015-10-01 Thread Josh Cartwright
Hello Maciek- Some architectural questions below: On Thu, Oct 01, 2015 at 04:04:31PM +0200, Maciek Borzecki wrote: > The patch adds LED triggers for indicating an activity on a selected > device. The drivers that intend to use triggers need to register > respective devices using ledtrig_dev_add()

[PATCH v2 1/3] leds: add device activity LED triggers

2015-10-01 Thread Maciek Borzecki
The patch adds LED triggers for indicating an activity on a selected device. The drivers that intend to use triggers need to register respective devices using ledtrig_dev_add(). Triggers are generated by explicitly calling ledtrig_dev_activity(). Signed-off-by: Maciek Borzecki --- drivers/leds/t