Re: [PATCH v2 1/3] locking/rwsem/x86: Add stack frame dependency for __up_read()

2017-09-14 Thread Miguel Bernal Marin
On Thu, Sep 07, 2017 at 09:12:42AM +0200, Ingo Molnar wrote: > > * Miguel Bernal Marin wrote: > > > kernel/locking/rwsem.o: warning: objtool: up_read()+0x11: call without > > frame pointer save/setup > > > > The warning means gcc 7.2.0 placed the __up_read() inline asm (and its > > call instru

Re: [PATCH v2 1/3] locking/rwsem/x86: Add stack frame dependency for __up_read()

2017-09-07 Thread Ingo Molnar
* Miguel Bernal Marin wrote: > kernel/locking/rwsem.o: warning: objtool: up_read()+0x11: call without frame > pointer save/setup > > The warning means gcc 7.2.0 placed the __up_read() inline asm (and its > call instruction) before the frame pointer setup in up_read(), > which breaks frame poin

[PATCH v2 1/3] locking/rwsem/x86: Add stack frame dependency for __up_read()

2017-09-06 Thread Miguel Bernal Marin
kernel/locking/rwsem.o: warning: objtool: up_read()+0x11: call without frame pointer save/setup The warning means gcc 7.2.0 placed the __up_read() inline asm (and its call instruction) before the frame pointer setup in up_read(), which breaks frame pointer convention and can result in incorrect s