Re: [PATCH v2 1/3] mfd: syscon: Set name of regmap_config

2018-03-12 Thread Mark Brown
On Mon, Mar 12, 2018 at 02:07:42PM +, Lee Jones wrote: > On Wed, 07 Mar 2018, Mark Brown wrote: > > On Wed, Mar 07, 2018 at 04:54:05PM +, Lee Jones wrote: > > > Is that an Ack? > > No, it looked like the change was only for MFD? > Right, but you can still Review/Ack patches from other

Re: [PATCH v2 1/3] mfd: syscon: Set name of regmap_config

2018-03-12 Thread Mark Brown
On Mon, Mar 12, 2018 at 02:07:42PM +, Lee Jones wrote: > On Wed, 07 Mar 2018, Mark Brown wrote: > > On Wed, Mar 07, 2018 at 04:54:05PM +, Lee Jones wrote: > > > Is that an Ack? > > No, it looked like the change was only for MFD? > Right, but you can still Review/Ack patches from other

Re: [PATCH v2 1/3] mfd: syscon: Set name of regmap_config

2018-03-12 Thread Lee Jones
On Wed, 07 Mar 2018, Mark Brown wrote: > On Wed, Mar 07, 2018 at 04:54:05PM +, Lee Jones wrote: > > On Wed, 07 Mar 2018, Mark Brown wrote: > > > On Wed, Mar 07, 2018 at 06:50:08PM +0800, JeffyChen wrote: > > > > Yes, like I say I think that's a good idea anyway - that sort of usage > > > is

Re: [PATCH v2 1/3] mfd: syscon: Set name of regmap_config

2018-03-12 Thread Lee Jones
On Wed, 07 Mar 2018, Mark Brown wrote: > On Wed, Mar 07, 2018 at 04:54:05PM +, Lee Jones wrote: > > On Wed, 07 Mar 2018, Mark Brown wrote: > > > On Wed, Mar 07, 2018 at 06:50:08PM +0800, JeffyChen wrote: > > > > Yes, like I say I think that's a good idea anyway - that sort of usage > > > is

Re: [PATCH v2 1/3] mfd: syscon: Set name of regmap_config

2018-03-07 Thread Mark Brown
On Wed, Mar 07, 2018 at 04:54:05PM +, Lee Jones wrote: > On Wed, 07 Mar 2018, Mark Brown wrote: > > On Wed, Mar 07, 2018 at 06:50:08PM +0800, JeffyChen wrote: > > Yes, like I say I think that's a good idea anyway - that sort of usage > > is the reason we've got the facility to set an explicit

Re: [PATCH v2 1/3] mfd: syscon: Set name of regmap_config

2018-03-07 Thread Mark Brown
On Wed, Mar 07, 2018 at 04:54:05PM +, Lee Jones wrote: > On Wed, 07 Mar 2018, Mark Brown wrote: > > On Wed, Mar 07, 2018 at 06:50:08PM +0800, JeffyChen wrote: > > Yes, like I say I think that's a good idea anyway - that sort of usage > > is the reason we've got the facility to set an explicit

Re: [PATCH v2 1/3] mfd: syscon: Set name of regmap_config

2018-03-07 Thread Lee Jones
On Wed, 07 Mar 2018, Mark Brown wrote: > On Wed, Mar 07, 2018 at 06:50:08PM +0800, JeffyChen wrote: > > > so i sent this patch to fix that by using the of_node name to create > > debugfs. > > > but later i found we have: > > commit a430ab205d29e7d1537b220fcf989b8080d8267f > > Author: Fabio

Re: [PATCH v2 1/3] mfd: syscon: Set name of regmap_config

2018-03-07 Thread Lee Jones
On Wed, 07 Mar 2018, Mark Brown wrote: > On Wed, Mar 07, 2018 at 06:50:08PM +0800, JeffyChen wrote: > > > so i sent this patch to fix that by using the of_node name to create > > debugfs. > > > but later i found we have: > > commit a430ab205d29e7d1537b220fcf989b8080d8267f > > Author: Fabio

Re: [PATCH v2 1/3] mfd: syscon: Set name of regmap_config

2018-03-07 Thread Mark Brown
On Wed, Mar 07, 2018 at 06:50:08PM +0800, JeffyChen wrote: > so i sent this patch to fix that by using the of_node name to create > debugfs. > but later i found we have: > commit a430ab205d29e7d1537b220fcf989b8080d8267f > Author: Fabio Estevam > Date: Mon Mar 5 15:52:09

Re: [PATCH v2 1/3] mfd: syscon: Set name of regmap_config

2018-03-07 Thread Mark Brown
On Wed, Mar 07, 2018 at 06:50:08PM +0800, JeffyChen wrote: > so i sent this patch to fix that by using the of_node name to create > debugfs. > but later i found we have: > commit a430ab205d29e7d1537b220fcf989b8080d8267f > Author: Fabio Estevam > Date: Mon Mar 5 15:52:09 2018 -0300 >

Re: [PATCH v2 1/3] mfd: syscon: Set name of regmap_config

2018-03-07 Thread JeffyChen
Hi Mark, On 03/07/2018 06:20 PM, Mark Brown wrote: On Tue, Mar 06, 2018 at 10:58:26PM +0800, JeffyChen wrote: even this is already fixed by a430ab205d29 ("regmap: debugfs: Disambiguate dummy debugfs file name") but maybe we can still have this for a better debugfs name? That's why the

Re: [PATCH v2 1/3] mfd: syscon: Set name of regmap_config

2018-03-07 Thread JeffyChen
Hi Mark, On 03/07/2018 06:20 PM, Mark Brown wrote: On Tue, Mar 06, 2018 at 10:58:26PM +0800, JeffyChen wrote: even this is already fixed by a430ab205d29 ("regmap: debugfs: Disambiguate dummy debugfs file name") but maybe we can still have this for a better debugfs name? That's why the

Re: [PATCH v2 1/3] mfd: syscon: Set name of regmap_config

2018-03-07 Thread Mark Brown
On Tue, Mar 06, 2018 at 10:58:26PM +0800, JeffyChen wrote: > even this is already fixed by a430ab205d29 ("regmap: debugfs: Disambiguate > dummy debugfs file name") > but maybe we can still have this for a better debugfs name? That's why the facility is there. Please don't top post, reply in

Re: [PATCH v2 1/3] mfd: syscon: Set name of regmap_config

2018-03-07 Thread Mark Brown
On Tue, Mar 06, 2018 at 10:58:26PM +0800, JeffyChen wrote: > even this is already fixed by a430ab205d29 ("regmap: debugfs: Disambiguate > dummy debugfs file name") > but maybe we can still have this for a better debugfs name? That's why the facility is there. Please don't top post, reply in

Re: [PATCH v2 1/3] mfd: syscon: Set name of regmap_config

2018-03-06 Thread JeffyChen
+CC Mark. even this is already fixed by a430ab205d29 ("regmap: debugfs: Disambiguate dummy debugfs file name") but maybe we can still have this for a better debugfs name? On 03/06/2018 07:04 PM, Jeffy Chen wrote: We are now allowing to register debugfs for syscon regmap, and not having a

Re: [PATCH v2 1/3] mfd: syscon: Set name of regmap_config

2018-03-06 Thread JeffyChen
+CC Mark. even this is already fixed by a430ab205d29 ("regmap: debugfs: Disambiguate dummy debugfs file name") but maybe we can still have this for a better debugfs name? On 03/06/2018 07:04 PM, Jeffy Chen wrote: We are now allowing to register debugfs for syscon regmap, and not having a

[PATCH v2 1/3] mfd: syscon: Set name of regmap_config

2018-03-06 Thread Jeffy Chen
We are now allowing to register debugfs for syscon regmap, and not having a valid name will end up using "dummy" to create debugfs dir. Fixes: 9b947a13e7f6 ("regmap: use debugfs even when no device") Signed-off-by: Jeffy Chen --- drivers/mfd/syscon.c | 1 + 1 file

[PATCH v2 1/3] mfd: syscon: Set name of regmap_config

2018-03-06 Thread Jeffy Chen
We are now allowing to register debugfs for syscon regmap, and not having a valid name will end up using "dummy" to create debugfs dir. Fixes: 9b947a13e7f6 ("regmap: use debugfs even when no device") Signed-off-by: Jeffy Chen --- drivers/mfd/syscon.c | 1 + 1 file changed, 1 insertion(+) diff