Re: [PATCH v2 1/3] mm: Cleanup faultaround and finish_fault() codepaths

2021-01-11 Thread Will Deacon
On Mon, Jan 11, 2021 at 05:26:20PM +0300, Kirill A. Shutemov wrote: > On Fri, Jan 08, 2021 at 05:15:15PM +, Will Deacon wrote: > > diff --git a/include/linux/mm.h b/include/linux/mm.h > > index ecdf8a8cd6ae..801dd99f733c 100644 > > --- a/include/linux/mm.h > > +++ b/include/linux/mm.h > > @@ -5

Re: [PATCH v2 1/3] mm: Cleanup faultaround and finish_fault() codepaths

2021-01-11 Thread Kirill A. Shutemov
On Fri, Jan 08, 2021 at 05:15:15PM +, Will Deacon wrote: > From: "Kirill A. Shutemov" > > alloc_set_pte() has two users with different requirements: in the > faultaround code, it called from an atomic context and PTE page table > has to be preallocated. finish_fault() can sleep and allocate p

[PATCH v2 1/3] mm: Cleanup faultaround and finish_fault() codepaths

2021-01-08 Thread Will Deacon
From: "Kirill A. Shutemov" alloc_set_pte() has two users with different requirements: in the faultaround code, it called from an atomic context and PTE page table has to be preallocated. finish_fault() can sleep and allocate page table as needed. PTL locking rules are also strange, hard to follo