Re: [PATCH v2 1/3] mm: memcontrol: fix swap counter leak on swapout from offline cgroup

2016-08-03 Thread Vladimir Davydov
On Wed, Aug 03, 2016 at 01:09:42PM +0200, Michal Hocko wrote: > On Wed 03-08-16 12:50:49, Vladimir Davydov wrote: > > On Tue, Aug 02, 2016 at 06:00:26PM +0200, Michal Hocko wrote: > > > On Tue 02-08-16 18:00:48, Vladimir Davydov wrote: > > ... > > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c

Re: [PATCH v2 1/3] mm: memcontrol: fix swap counter leak on swapout from offline cgroup

2016-08-03 Thread Vladimir Davydov
On Wed, Aug 03, 2016 at 10:12:03AM -0400, Johannes Weiner wrote: > On Wed, Aug 03, 2016 at 02:46:40PM +0300, Vladimir Davydov wrote: ... > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > index 1c0aa59fd333..8c8e68becee9 100644 > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -4044,7

Re: [PATCH v2 1/3] mm: memcontrol: fix swap counter leak on swapout from offline cgroup

2016-08-03 Thread Vladimir Davydov
On Tue, Aug 02, 2016 at 10:31:16PM +0200, Michal Hocko wrote: > On Tue 02-08-16 13:33:37, Johannes Weiner wrote: > > On Tue, Aug 02, 2016 at 06:00:26PM +0200, Michal Hocko wrote: > > > On Tue 02-08-16 18:00:48, Vladimir Davydov wrote: > > > > @@ -5767,15 +5785,20 @@ void mem_cgroup_swapout(struct p

Re: [PATCH v2 1/3] mm: memcontrol: fix swap counter leak on swapout from offline cgroup

2016-08-03 Thread Vladimir Davydov
On Tue, Aug 02, 2016 at 06:00:26PM +0200, Michal Hocko wrote: > On Tue 02-08-16 18:00:48, Vladimir Davydov wrote: ... > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > index 3be791afd372..4ae12effe347 100644 > > --- a/mm/memcontrol.c > > +++ b/mm/memcontrol.c > > @@ -4036,6 +4036,24 @@ static

Re: [PATCH v2 1/3] mm: memcontrol: fix swap counter leak on swapout from offline cgroup

2016-08-03 Thread Johannes Weiner
On Wed, Aug 03, 2016 at 02:46:40PM +0300, Vladimir Davydov wrote: > On Wed, Aug 03, 2016 at 01:09:42PM +0200, Michal Hocko wrote: > > On Wed 03-08-16 12:50:49, Vladimir Davydov wrote: > > > On Tue, Aug 02, 2016 at 06:00:26PM +0200, Michal Hocko wrote: > > > > On Tue 02-08-16 18:00:48, Vladimir Davy

Re: [PATCH v2 1/3] mm: memcontrol: fix swap counter leak on swapout from offline cgroup

2016-08-03 Thread Michal Hocko
On Wed 03-08-16 14:46:40, Vladimir Davydov wrote: > On Wed, Aug 03, 2016 at 01:09:42PM +0200, Michal Hocko wrote: > > On Wed 03-08-16 12:50:49, Vladimir Davydov wrote: > > > On Tue, Aug 02, 2016 at 06:00:26PM +0200, Michal Hocko wrote: > > > > On Tue 02-08-16 18:00:48, Vladimir Davydov wrote: > > >

Re: [PATCH v2 1/3] mm: memcontrol: fix swap counter leak on swapout from offline cgroup

2016-08-03 Thread Michal Hocko
On Wed 03-08-16 12:50:49, Vladimir Davydov wrote: > On Tue, Aug 02, 2016 at 06:00:26PM +0200, Michal Hocko wrote: > > On Tue 02-08-16 18:00:48, Vladimir Davydov wrote: > ... > > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > > > index 3be791afd372..4ae12effe347 100644 > > > --- a/mm/memcontrol.

Re: [PATCH v2 1/3] mm: memcontrol: fix swap counter leak on swapout from offline cgroup

2016-08-02 Thread Michal Hocko
On Tue 02-08-16 13:33:37, Johannes Weiner wrote: > On Tue, Aug 02, 2016 at 06:00:26PM +0200, Michal Hocko wrote: > > On Tue 02-08-16 18:00:48, Vladimir Davydov wrote: > > > @@ -5767,15 +5785,20 @@ void mem_cgroup_swapout(struct page *page, > > > swp_entry_t entry) > > > if (!memcg) > > >

Re: [PATCH v2 1/3] mm: memcontrol: fix swap counter leak on swapout from offline cgroup

2016-08-02 Thread Johannes Weiner
On Tue, Aug 02, 2016 at 06:00:48PM +0300, Vladimir Davydov wrote: > An offline memory cgroup might have anonymous memory or shmem left > charged to it and no swap. Since only swap entries pin the id of an > offline cgroup, such a cgroup will have no id and so an attempt to > swapout its anon/shmem

[PATCH v2 1/3] mm: memcontrol: fix swap counter leak on swapout from offline cgroup

2016-08-02 Thread Vladimir Davydov
An offline memory cgroup might have anonymous memory or shmem left charged to it and no swap. Since only swap entries pin the id of an offline cgroup, such a cgroup will have no id and so an attempt to swapout its anon/shmem will not store memory cgroup info in the swap cgroup map. As a result, mem

Re: [PATCH v2 1/3] mm: memcontrol: fix swap counter leak on swapout from offline cgroup

2016-08-02 Thread Johannes Weiner
On Tue, Aug 02, 2016 at 06:00:26PM +0200, Michal Hocko wrote: > On Tue 02-08-16 18:00:48, Vladimir Davydov wrote: > > @@ -5767,15 +5785,20 @@ void mem_cgroup_swapout(struct page *page, > > swp_entry_t entry) > > if (!memcg) > > return; > > > > - mem_cgroup_id_get(memcg); > > -

Re: [PATCH v2 1/3] mm: memcontrol: fix swap counter leak on swapout from offline cgroup

2016-08-02 Thread Michal Hocko
On Tue 02-08-16 18:00:48, Vladimir Davydov wrote: > An offline memory cgroup might have anonymous memory or shmem left > charged to it and no swap. Since only swap entries pin the id of an > offline cgroup, such a cgroup will have no id and so an attempt to > swapout its anon/shmem will not store m