Re: [PATCH v2 1/3] perf tools: Fix dso__data_read_offset() file opening

2015-05-21 Thread Arnaldo Carvalho de Melo
Em Thu, May 21, 2015 at 10:03:27AM +0300, Adrian Hunter escreveu: > On 20/05/15 19:03, Namhyung Kim wrote: > > When dso__data_read_offset/addr() is called without prior > > dso__data_fd() (or other functions which call it internally), it > > failed to open dso in data_file_size() since its binary t

Re: [PATCH v2 1/3] perf tools: Fix dso__data_read_offset() file opening

2015-05-21 Thread Adrian Hunter
On 20/05/15 19:03, Namhyung Kim wrote: > When dso__data_read_offset/addr() is called without prior > dso__data_fd() (or other functions which call it internally), it > failed to open dso in data_file_size() since its binary type was not > identified. > > However calling dso__data_fd() in dso__data

[PATCH v2 1/3] perf tools: Fix dso__data_read_offset() file opening

2015-05-20 Thread Namhyung Kim
When dso__data_read_offset/addr() is called without prior dso__data_fd() (or other functions which call it internally), it failed to open dso in data_file_size() since its binary type was not identified. However calling dso__data_fd() in dso__data_read_offset() will hurt performance as it grabs a