Re: [PATCH v2 1/3] printk: fix name/type/scope of preferred_console var

2017-03-14 Thread Petr Mladek
On Thu 2017-03-02 16:11:32, Aleksey Makarov wrote: > The variable preferred_console is used only inside register_console() > and its semantics is boolean. It is negative when no console has been > made preferred. > > Make it static bool and rename to has_preferred. > > Renaming was suggested by

Re: [PATCH v2 1/3] printk: fix name/type/scope of preferred_console var

2017-03-14 Thread Petr Mladek
On Thu 2017-03-02 16:11:32, Aleksey Makarov wrote: > The variable preferred_console is used only inside register_console() > and its semantics is boolean. It is negative when no console has been > made preferred. > > Make it static bool and rename to has_preferred. > > Renaming was suggested by

Re: [PATCH v2 1/3] printk: fix name/type/scope of preferred_console var

2017-03-02 Thread Sergey Senozhatsky
On (03/02/17 09:49), Steven Rostedt wrote: > > The variable preferred_console is used only inside register_console() > > and its semantics is boolean. It is negative when no console has been > > made preferred. > > > > Make it static bool and rename to has_preferred. > > > > Renaming was

Re: [PATCH v2 1/3] printk: fix name/type/scope of preferred_console var

2017-03-02 Thread Sergey Senozhatsky
On (03/02/17 09:49), Steven Rostedt wrote: > > The variable preferred_console is used only inside register_console() > > and its semantics is boolean. It is negative when no console has been > > made preferred. > > > > Make it static bool and rename to has_preferred. > > > > Renaming was

Re: [PATCH v2 1/3] printk: fix name/type/scope of preferred_console var

2017-03-02 Thread Steven Rostedt
On Thu, 2 Mar 2017 16:11:32 +0300 Aleksey Makarov wrote: > The variable preferred_console is used only inside register_console() > and its semantics is boolean. It is negative when no console has been > made preferred. > > Make it static bool and rename to

Re: [PATCH v2 1/3] printk: fix name/type/scope of preferred_console var

2017-03-02 Thread Steven Rostedt
On Thu, 2 Mar 2017 16:11:32 +0300 Aleksey Makarov wrote: > The variable preferred_console is used only inside register_console() > and its semantics is boolean. It is negative when no console has been > made preferred. > > Make it static bool and rename to has_preferred. > > Renaming was

[PATCH v2 1/3] printk: fix name/type/scope of preferred_console var

2017-03-02 Thread Aleksey Makarov
The variable preferred_console is used only inside register_console() and its semantics is boolean. It is negative when no console has been made preferred. Make it static bool and rename to has_preferred. Renaming was suggested by Peter Hurley Signed-off-by: Aleksey Makarov

[PATCH v2 1/3] printk: fix name/type/scope of preferred_console var

2017-03-02 Thread Aleksey Makarov
The variable preferred_console is used only inside register_console() and its semantics is boolean. It is negative when no console has been made preferred. Make it static bool and rename to has_preferred. Renaming was suggested by Peter Hurley Signed-off-by: Aleksey Makarov ---