Re: [PATCH v2 1/3] pwm: Add pwm_cansleep() as exported API to users

2013-01-28 Thread Florian Vaussard
Hello, Le 28/01/2013 16:01, Russell King - ARM Linux a écrit : On Mon, Jan 28, 2013 at 10:36:07AM +0100, Florian Vaussard wrote: Hello, Le 28/01/2013 09:45, Peter Ujfalusi a écrit : hi Thierry, On 01/26/2013 06:40 AM, Thierry Reding wrote: +{ + return pwm->chip->can_sleep; +} +EXPORT_

Re: [PATCH v2 1/3] pwm: Add pwm_cansleep() as exported API to users

2013-01-28 Thread Russell King - ARM Linux
On Mon, Jan 28, 2013 at 10:36:07AM +0100, Florian Vaussard wrote: > Hello, > > Le 28/01/2013 09:45, Peter Ujfalusi a écrit : >> hi Thierry, >> >> On 01/26/2013 06:40 AM, Thierry Reding wrote: +{ + return pwm->chip->can_sleep; +} +EXPORT_SYMBOL_GPL(pwm_cansleep); >>> >>> Would i

Re: [PATCH v2 1/3] pwm: Add pwm_cansleep() as exported API to users

2013-01-28 Thread Thierry Reding
On Mon, Jan 28, 2013 at 11:57:39AM +0100, Florian Vaussard wrote: > Le 28/01/2013 10:57, Thierry Reding a écrit : > >On Mon, Jan 28, 2013 at 10:36:07AM +0100, Florian Vaussard wrote: > >>Hello, > >> > >>Le 28/01/2013 09:45, Peter Ujfalusi a écrit : > >>>hi Thierry, > >>> > >>>On 01/26/2013 06:40 AM

Re: [PATCH v2 1/3] pwm: Add pwm_cansleep() as exported API to users

2013-01-28 Thread Florian Vaussard
Le 28/01/2013 10:57, Thierry Reding a écrit : On Mon, Jan 28, 2013 at 10:36:07AM +0100, Florian Vaussard wrote: Hello, Le 28/01/2013 09:45, Peter Ujfalusi a écrit : hi Thierry, On 01/26/2013 06:40 AM, Thierry Reding wrote: [...] +{ + return pwm->chip->can_sleep; +} +EXPORT_SYMBOL_GPL(

Re: [PATCH v2 1/3] pwm: Add pwm_cansleep() as exported API to users

2013-01-28 Thread Thierry Reding
On Mon, Jan 28, 2013 at 10:36:07AM +0100, Florian Vaussard wrote: > Hello, > > Le 28/01/2013 09:45, Peter Ujfalusi a écrit : > >hi Thierry, > > > >On 01/26/2013 06:40 AM, Thierry Reding wrote: [...] > >>>+{ > >>>+ return pwm->chip->can_sleep; > >>>+} > >>>+EXPORT_SYMBOL_GPL(pwm_cansleep); > >> >

Re: [PATCH v2 1/3] pwm: Add pwm_cansleep() as exported API to users

2013-01-28 Thread Florian Vaussard
Hello, Le 28/01/2013 09:45, Peter Ujfalusi a écrit : hi Thierry, On 01/26/2013 06:40 AM, Thierry Reding wrote: + * @pwm: PWM device + * + * It returns nonzero if accessing the PWM can sleep. + */ +int pwm_cansleep(struct pwm_device *pwm) I actually liked pwm_can_sleep() better. I find it

Re: [PATCH v2 1/3] pwm: Add pwm_cansleep() as exported API to users

2013-01-28 Thread Peter Ujfalusi
hi Thierry, On 01/26/2013 06:40 AM, Thierry Reding wrote: >> + * @pwm: PWM device >> + * >> + * It returns nonzero if accessing the PWM can sleep. >> + */ >> +int pwm_cansleep(struct pwm_device *pwm) > > I actually liked pwm_can_sleep() better. I find it to be more consistent > with the namin

Re: [PATCH v2 1/3] pwm: Add pwm_cansleep() as exported API to users

2013-01-25 Thread Thierry Reding
On Fri, Jan 25, 2013 at 02:44:29PM +0100, Florian Vaussard wrote: > Calls to some external PWM chips can sleep. To help users, > add pwm_cansleep() API. > > Signed-off-by: Florian Vaussard > --- > drivers/pwm/core.c | 12 > include/linux/pwm.h | 10 ++ > 2 files changed

Re: [PATCH v2 1/3] pwm: Add pwm_cansleep() as exported API to users

2013-01-25 Thread Peter Ujfalusi
On 01/25/2013 02:44 PM, Florian Vaussard wrote: > Calls to some external PWM chips can sleep. To help users, > add pwm_cansleep() API. > > Signed-off-by: Florian Vaussard Reviewed-by: Peter Ujfalusi > --- > drivers/pwm/core.c | 12 > include/linux/pwm.h | 10 ++ > 2

[PATCH v2 1/3] pwm: Add pwm_cansleep() as exported API to users

2013-01-25 Thread Florian Vaussard
Calls to some external PWM chips can sleep. To help users, add pwm_cansleep() API. Signed-off-by: Florian Vaussard --- drivers/pwm/core.c | 12 include/linux/pwm.h | 10 ++ 2 files changed, 22 insertions(+), 0 deletions(-) diff --git a/drivers/pwm/core.c b/drivers/pwm/