Re: [PATCH v2 1/3] rtc: omap: Unlock and Lock rtc registers before and after register writes

2015-04-02 Thread Alexandre Belloni
Hi, On 02/04/2015 at 18:14:11 +0530, Lokesh Vutla wrote : > Here is the updated patch. > You should probably send it properly using git send-email, have a look at the --in-reply-to parameter, else, I'm not sure Andrew will be able to pick it up. Thanks! -- Alexandre Belloni, Free Electrons Em

Re: [PATCH v2 1/3] rtc: omap: Unlock and Lock rtc registers before and after register writes

2015-04-02 Thread Lokesh Vutla
On Thursday 02 April 2015 06:03 PM, Alexandre Belloni wrote: > On 02/04/2015 at 16:39:09 +0530, Lokesh Vutla wrote : [..snip..] >> } >> >> +static inline void am3352_rtc_unlock(struct omap_rtc *rtc) >> +{ >> +rtc_writel(rtc, OMAP_RTC_KICK0_REG, KICK0_VALUE); >> +rtc_writel(rtc, OMAP_RTC

Re: [PATCH v2 1/3] rtc: omap: Unlock and Lock rtc registers before and after register writes

2015-04-02 Thread Alexandre Belloni
On 02/04/2015 at 16:39:09 +0530, Lokesh Vutla wrote : > RTC module contains a kicker mechanism to prevent any spurious writes > from changing the register values. This mechanism requires two MMR > writes to the KICK0 and KICK1 registers with exact data values > before the kicker lock mechanism is r

[PATCH v2 1/3] rtc: omap: Unlock and Lock rtc registers before and after register writes

2015-04-02 Thread Lokesh Vutla
RTC module contains a kicker mechanism to prevent any spurious writes from changing the register values. This mechanism requires two MMR writes to the KICK0 and KICK1 registers with exact data values before the kicker lock mechanism is released. Currently the driver release the lock in the probe a