Re: [PATCH v2 1/3] slub: correct to calculate num of acquired objects in get_partial_node()

2013-04-02 Thread Christoph Lameter
On Tue, 2 Apr 2013, Pekka Enberg wrote: > On Tue, Mar 19, 2013 at 7:10 AM, Joonsoo Kim wrote: > > Could you pick up 1/3, 3/3? > > These are already acked by Christoph. > > 2/3 is same effect as Glauber's "slub: correctly bootstrap boot caches", > > so should skip it. > > Applied, thanks! Could

Re: [PATCH v2 1/3] slub: correct to calculate num of acquired objects in get_partial_node()

2013-04-02 Thread Pekka Enberg
On Tue, Mar 19, 2013 at 7:10 AM, Joonsoo Kim wrote: > Could you pick up 1/3, 3/3? > These are already acked by Christoph. > 2/3 is same effect as Glauber's "slub: correctly bootstrap boot caches", > so should skip it. Applied, thanks! -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH v2 1/3] slub: correct to calculate num of acquired objects in get_partial_node()

2013-04-02 Thread Pekka Enberg
On Tue, Mar 19, 2013 at 7:10 AM, Joonsoo Kim iamjoonsoo@lge.com wrote: Could you pick up 1/3, 3/3? These are already acked by Christoph. 2/3 is same effect as Glauber's slub: correctly bootstrap boot caches, so should skip it. Applied, thanks! -- To unsubscribe from this list: send the

Re: [PATCH v2 1/3] slub: correct to calculate num of acquired objects in get_partial_node()

2013-04-02 Thread Christoph Lameter
On Tue, 2 Apr 2013, Pekka Enberg wrote: On Tue, Mar 19, 2013 at 7:10 AM, Joonsoo Kim iamjoonsoo@lge.com wrote: Could you pick up 1/3, 3/3? These are already acked by Christoph. 2/3 is same effect as Glauber's slub: correctly bootstrap boot caches, so should skip it. Applied,

Re: [PATCH v2 1/3] slub: correct to calculate num of acquired objects in get_partial_node()

2013-03-18 Thread Joonsoo Kim
Hello, Pekka. Could you pick up 1/3, 3/3? These are already acked by Christoph. 2/3 is same effect as Glauber's "slub: correctly bootstrap boot caches", so should skip it. Thanks. On Mon, Jan 21, 2013 at 05:01:25PM +0900, Joonsoo Kim wrote: > There is a subtle bug when calculating a number of

Re: [PATCH v2 1/3] slub: correct to calculate num of acquired objects in get_partial_node()

2013-03-18 Thread Joonsoo Kim
Hello, Pekka. Could you pick up 1/3, 3/3? These are already acked by Christoph. 2/3 is same effect as Glauber's slub: correctly bootstrap boot caches, so should skip it. Thanks. On Mon, Jan 21, 2013 at 05:01:25PM +0900, Joonsoo Kim wrote: There is a subtle bug when calculating a number of

Re: [PATCH v2 1/3] slub: correct to calculate num of acquired objects in get_partial_node()

2013-01-23 Thread Christoph Lameter
On Mon, 21 Jan 2013, Joonsoo Kim wrote: > v2: calculate nr of objects using new.objects and new.inuse. > It is more accurate way than before. Acked-by: Christoph Lameter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH v2 1/3] slub: correct to calculate num of acquired objects in get_partial_node()

2013-01-23 Thread Christoph Lameter
On Mon, 21 Jan 2013, Joonsoo Kim wrote: v2: calculate nr of objects using new.objects and new.inuse. It is more accurate way than before. Acked-by: Christoph Lameter c...@linux.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

[PATCH v2 1/3] slub: correct to calculate num of acquired objects in get_partial_node()

2013-01-21 Thread Joonsoo Kim
There is a subtle bug when calculating a number of acquired objects. Currently, we calculate "available = page->objects - page->inuse", after acquire_slab() is called in get_partial_node(). In acquire_slab() with mode = 1, we always set new.inuse = page->objects. So, acquire_slab(s, n,

[PATCH v2 1/3] slub: correct to calculate num of acquired objects in get_partial_node()

2013-01-21 Thread Joonsoo Kim
There is a subtle bug when calculating a number of acquired objects. Currently, we calculate available = page-objects - page-inuse, after acquire_slab() is called in get_partial_node(). In acquire_slab() with mode = 1, we always set new.inuse = page-objects. So, acquire_slab(s, n, page,