Re: [PATCH v2 1/3] tpm_tis: Disable interrupt auto probing on a per-device basis

2015-12-01 Thread Jason Gunthorpe
On Tue, Dec 01, 2015 at 08:19:18PM +0100, Uwe Kleine-König wrote: > I'd add a comment here about the possible values of irq and their > interpretation. Something like: Done > It's definitly a nice improvement of this patch that the init functions > don't change the module parameter any more. (I d

Re: [PATCH v2 1/3] tpm_tis: Disable interrupt auto probing on a per-device basis

2015-12-01 Thread Uwe Kleine-König
Hello, On Tue, Dec 01, 2015 at 11:58:27AM -0700, Jason Gunthorpe wrote: > Instead of clearing the global interrupts flag when any device > does not have an interrupt just pass -1 through tpm_info.irq. > > The only thing that asks for autoprobing is the force=1 path. > > Signed-off-by: Jason Gunt

[PATCH v2 1/3] tpm_tis: Disable interrupt auto probing on a per-device basis

2015-12-01 Thread Jason Gunthorpe
Instead of clearing the global interrupts flag when any device does not have an interrupt just pass -1 through tpm_info.irq. The only thing that asks for autoprobing is the force=1 path. Signed-off-by: Jason Gunthorpe --- drivers/char/tpm/tpm_tis.c | 16 +++- 1 file changed, 7 inser