Re: [PATCH v2 1/4] devicetree: bindings: Properly document micrel ks8851 SPI chips

2014-05-28 Thread Mark Brown
On Wed, May 28, 2014 at 12:44:35PM -0700, Stephen Boyd wrote: > On 05/28/14 10:12, Mark Brown wrote: > > If the supply must always be physically present the bindings should be > > specified as it being mandatory and the code written in that fashion; as > > an extension Linux will put a dummy in bu

Re: [PATCH v2 1/4] devicetree: bindings: Properly document micrel ks8851 SPI chips

2014-05-28 Thread Stephen Boyd
On 05/28/14 10:12, Mark Brown wrote: > On Wed, May 28, 2014 at 05:16:46PM +0200, Uwe Kleine-König wrote: >> On Tue, May 27, 2014 at 02:40:15PM -0700, Stephen Boyd wrote: >>> On 05/24/14 05:48, Mark Brown wrote: So, according to the datasheet I managed to find this device has a supply VDD_

Re: [PATCH v2 1/4] devicetree: bindings: Properly document micrel ks8851 SPI chips

2014-05-28 Thread Mark Brown
On Wed, May 28, 2014 at 05:16:46PM +0200, Uwe Kleine-König wrote: > On Tue, May 27, 2014 at 02:40:15PM -0700, Stephen Boyd wrote: > > On 05/24/14 05:48, Mark Brown wrote: > > > So, according to the datasheet I managed to find this device has a > > > supply VDD_IO (so normally written vdd-io-supply

Re: [PATCH v2 1/4] devicetree: bindings: Properly document micrel ks8851 SPI chips

2014-05-28 Thread Rob Herring
On Wed, May 28, 2014 at 10:16 AM, Uwe Kleine-König wrote: > Hello Stephen, > > On Tue, May 27, 2014 at 02:40:15PM -0700, Stephen Boyd wrote: >> On 05/24/14 05:48, Mark Brown wrote: >> > On Fri, May 23, 2014 at 12:57:17PM -0700, Stephen Boyd wrote: >> > >> >> Optional properties: >> >> -- vdd-supp

Re: [PATCH v2 1/4] devicetree: bindings: Properly document micrel ks8851 SPI chips

2014-05-28 Thread Uwe Kleine-König
Hello Stephen, On Tue, May 27, 2014 at 02:40:15PM -0700, Stephen Boyd wrote: > On 05/24/14 05:48, Mark Brown wrote: > > On Fri, May 23, 2014 at 12:57:17PM -0700, Stephen Boyd wrote: > > > >> Optional properties: > >> -- vdd-supply: supply for Ethernet mac > >> +- vdd-supply: analog 3.3V suppl

Re: [PATCH v2 1/4] devicetree: bindings: Properly document micrel ks8851 SPI chips

2014-05-28 Thread Mark Brown
On Tue, May 27, 2014 at 02:40:15PM -0700, Stephen Boyd wrote: > On 05/24/14 05:48, Mark Brown wrote: > > That said it looks like this is intended to be a supply for an external > > PHY rather than the device itself, but even so my original question > > about it being able to operate without power

Re: [PATCH v2 1/4] devicetree: bindings: Properly document micrel ks8851 SPI chips

2014-05-27 Thread Stephen Boyd
On 05/24/14 05:48, Mark Brown wrote: > On Fri, May 23, 2014 at 12:57:17PM -0700, Stephen Boyd wrote: > >> Optional properties: >> -- vdd-supply: supply for Ethernet mac >> +- vdd-supply: analog 3.3V supply for Ethernet mac >> +- vdd-io-supply: digital 1.8V IO supply for Ethernet mac > So, ac

Re: [PATCH v2 1/4] devicetree: bindings: Properly document micrel ks8851 SPI chips

2014-05-24 Thread Mark Brown
On Fri, May 23, 2014 at 12:57:17PM -0700, Stephen Boyd wrote: > Optional properties: > -- vdd-supply:supply for Ethernet mac > +- vdd-supply: analog 3.3V supply for Ethernet mac > +- vdd-io-supply: digital 1.8V IO supply for Ethernet mac So, according to the datasheet I managed to find t

Re: [PATCH v2 1/4] devicetree: bindings: Properly document micrel ks8851 SPI chips

2014-05-24 Thread Mark Brown
On Fri, May 23, 2014 at 12:57:17PM -0700, Stephen Boyd wrote: > Optional properties: > -- vdd-supply:supply for Ethernet mac > +- vdd-supply: analog 3.3V supply for Ethernet mac > +- vdd-io-supply: digital 1.8V IO supply for Ethernet mac > +- reset-gpios: reset_n input pin Are we *positi

[PATCH v2 1/4] devicetree: bindings: Properly document micrel ks8851 SPI chips

2014-05-23 Thread Stephen Boyd
The ks8851 SPI ethernet wasn't documented, but we documented the optional regulator supply for it under the mll based ethernet chip. Furthermore, that compatible string needed another 'l'. Fix all of this and document the optional vdd-io and reset-gpios properties. Cc: Nishanth Menon Cc: Rob Herr