Re: [PATCH v2 1/4] dmaengine: xilinx_dma: populate dma caps properly

2018-01-10 Thread Vinod Koul
On Tue, Jan 09, 2018 at 07:36:11AM +, Appana Durga Kedareswara Rao wrote: > Hi, > > Thanks for the review... > > >On Tue, Jan 09, 2018 at 04:48:10AM +, Appana Durga Kedareswara Rao > >wrote: > >> Hi, > >> > >> >On Mon, Jan 08, 2018 at 05:25:01PM +, Appana Durga Kedareswara >

Re: [PATCH v2 1/4] dmaengine: xilinx_dma: populate dma caps properly

2018-01-10 Thread Vinod Koul
On Tue, Jan 09, 2018 at 07:36:11AM +, Appana Durga Kedareswara Rao wrote: > Hi, > > Thanks for the review... > > >On Tue, Jan 09, 2018 at 04:48:10AM +, Appana Durga Kedareswara Rao > >wrote: > >> Hi, > >> > >> >On Mon, Jan 08, 2018 at 05:25:01PM +, Appana Durga Kedareswara >

RE: [PATCH v2 1/4] dmaengine: xilinx_dma: populate dma caps properly

2018-01-08 Thread Appana Durga Kedareswara Rao
Hi, Thanks for the review... >On Tue, Jan 09, 2018 at 04:48:10AM +, Appana Durga Kedareswara Rao >wrote: >> Hi, >> >> >On Mon, Jan 08, 2018 at 05:25:01PM +, Appana Durga Kedareswara >> >Rao >> >wrote: >> >> Hi, >> >> >> >> >> >> >> >> + xdev->common.dst_addr_widths =

RE: [PATCH v2 1/4] dmaengine: xilinx_dma: populate dma caps properly

2018-01-08 Thread Appana Durga Kedareswara Rao
Hi, Thanks for the review... >On Tue, Jan 09, 2018 at 04:48:10AM +, Appana Durga Kedareswara Rao >wrote: >> Hi, >> >> >On Mon, Jan 08, 2018 at 05:25:01PM +, Appana Durga Kedareswara >> >Rao >> >wrote: >> >> Hi, >> >> >> >> >> >> >> >> + xdev->common.dst_addr_widths =

Re: [PATCH v2 1/4] dmaengine: xilinx_dma: populate dma caps properly

2018-01-08 Thread Vinod Koul
On Tue, Jan 09, 2018 at 04:48:10AM +, Appana Durga Kedareswara Rao wrote: > Hi, > > >On Mon, Jan 08, 2018 at 05:25:01PM +, Appana Durga Kedareswara Rao > >wrote: > >> Hi, > >> > >> > >> >> >> +xdev->common.dst_addr_widths = BIT(addr_width / 8); > >> >> >> +

Re: [PATCH v2 1/4] dmaengine: xilinx_dma: populate dma caps properly

2018-01-08 Thread Vinod Koul
On Tue, Jan 09, 2018 at 04:48:10AM +, Appana Durga Kedareswara Rao wrote: > Hi, > > >On Mon, Jan 08, 2018 at 05:25:01PM +, Appana Durga Kedareswara Rao > >wrote: > >> Hi, > >> > >> > >> >> >> +xdev->common.dst_addr_widths = BIT(addr_width / 8); > >> >> >> +

RE: [PATCH v2 1/4] dmaengine: xilinx_dma: populate dma caps properly

2018-01-08 Thread Appana Durga Kedareswara Rao
Hi, >On Mon, Jan 08, 2018 at 05:25:01PM +, Appana Durga Kedareswara Rao >wrote: >> Hi, >> >> >> >> >> + xdev->common.dst_addr_widths = BIT(addr_width / 8); >> >> >> + xdev->common.src_addr_widths = BIT(addr_width / 8); >> >> > >> >> >Do you not support trf of 1byte, 2 bytes, or 4

RE: [PATCH v2 1/4] dmaengine: xilinx_dma: populate dma caps properly

2018-01-08 Thread Appana Durga Kedareswara Rao
Hi, >On Mon, Jan 08, 2018 at 05:25:01PM +, Appana Durga Kedareswara Rao >wrote: >> Hi, >> >> >> >> >> + xdev->common.dst_addr_widths = BIT(addr_width / 8); >> >> >> + xdev->common.src_addr_widths = BIT(addr_width / 8); >> >> > >> >> >Do you not support trf of 1byte, 2 bytes, or 4

Re: [PATCH v2 1/4] dmaengine: xilinx_dma: populate dma caps properly

2018-01-08 Thread Vinod Koul
On Mon, Jan 08, 2018 at 05:25:01PM +, Appana Durga Kedareswara Rao wrote: > Hi, > > > >> >> + xdev->common.dst_addr_widths = BIT(addr_width / 8); > >> >> + xdev->common.src_addr_widths = BIT(addr_width / 8); > >> > > >> >Do you not support trf of 1byte, 2 bytes, or 4 bytes wide

Re: [PATCH v2 1/4] dmaengine: xilinx_dma: populate dma caps properly

2018-01-08 Thread Vinod Koul
On Mon, Jan 08, 2018 at 05:25:01PM +, Appana Durga Kedareswara Rao wrote: > Hi, > > > >> >> + xdev->common.dst_addr_widths = BIT(addr_width / 8); > >> >> + xdev->common.src_addr_widths = BIT(addr_width / 8); > >> > > >> >Do you not support trf of 1byte, 2 bytes, or 4 bytes wide

RE: [PATCH v2 1/4] dmaengine: xilinx_dma: populate dma caps properly

2018-01-08 Thread Appana Durga Kedareswara Rao
Hi, >> >> + xdev->common.dst_addr_widths = BIT(addr_width / 8); >> >> + xdev->common.src_addr_widths = BIT(addr_width / 8); >> > >> >Do you not support trf of 1byte, 2 bytes, or 4 bytes wide transfers? >> >What is value of addr_width here typically? Usually controllers can >> >support different

RE: [PATCH v2 1/4] dmaengine: xilinx_dma: populate dma caps properly

2018-01-08 Thread Appana Durga Kedareswara Rao
Hi, >> >> + xdev->common.dst_addr_widths = BIT(addr_width / 8); >> >> + xdev->common.src_addr_widths = BIT(addr_width / 8); >> > >> >Do you not support trf of 1byte, 2 bytes, or 4 bytes wide transfers? >> >What is value of addr_width here typically? Usually controllers can >> >support different

Re: [PATCH v2 1/4] dmaengine: xilinx_dma: populate dma caps properly

2018-01-08 Thread Vinod Koul
On Mon, Jan 08, 2018 at 10:52:01AM +, Appana Durga Kedareswara Rao wrote: > Hi Vinod, > > Thanks for the review > > >> @@ -2398,6 +2398,7 @@ static int xilinx_dma_chan_probe(struct > >xilinx_dma_device *xdev, > >>chan->direction = DMA_MEM_TO_DEV; > >>

Re: [PATCH v2 1/4] dmaengine: xilinx_dma: populate dma caps properly

2018-01-08 Thread Vinod Koul
On Mon, Jan 08, 2018 at 10:52:01AM +, Appana Durga Kedareswara Rao wrote: > Hi Vinod, > > Thanks for the review > > >> @@ -2398,6 +2398,7 @@ static int xilinx_dma_chan_probe(struct > >xilinx_dma_device *xdev, > >>chan->direction = DMA_MEM_TO_DEV; > >>

RE: [PATCH v2 1/4] dmaengine: xilinx_dma: populate dma caps properly

2018-01-08 Thread Appana Durga Kedareswara Rao
Hi Vinod, Thanks for the review >> @@ -2398,6 +2398,7 @@ static int xilinx_dma_chan_probe(struct >xilinx_dma_device *xdev, >> chan->direction = DMA_MEM_TO_DEV; >> chan->id = chan_id; >> chan->tdest = chan_id; >> +

RE: [PATCH v2 1/4] dmaengine: xilinx_dma: populate dma caps properly

2018-01-08 Thread Appana Durga Kedareswara Rao
Hi Vinod, Thanks for the review >> @@ -2398,6 +2398,7 @@ static int xilinx_dma_chan_probe(struct >xilinx_dma_device *xdev, >> chan->direction = DMA_MEM_TO_DEV; >> chan->id = chan_id; >> chan->tdest = chan_id; >> +

Re: [PATCH v2 1/4] dmaengine: xilinx_dma: populate dma caps properly

2018-01-08 Thread Vinod Koul
On Wed, Jan 03, 2018 at 12:12:08PM +0530, Kedareswara rao Appana wrote: > When client driver uses dma_get_slave_caps() api, > it checks for certain fields of dma_device struct > currently driver is not settings the directions and addr_widths > fields resulting dma_get_slave_caps() returning

Re: [PATCH v2 1/4] dmaengine: xilinx_dma: populate dma caps properly

2018-01-08 Thread Vinod Koul
On Wed, Jan 03, 2018 at 12:12:08PM +0530, Kedareswara rao Appana wrote: > When client driver uses dma_get_slave_caps() api, > it checks for certain fields of dma_device struct > currently driver is not settings the directions and addr_widths > fields resulting dma_get_slave_caps() returning

[PATCH v2 1/4] dmaengine: xilinx_dma: populate dma caps properly

2018-01-02 Thread Kedareswara rao Appana
When client driver uses dma_get_slave_caps() api, it checks for certain fields of dma_device struct currently driver is not settings the directions and addr_widths fields resulting dma_get_slave_caps() returning failure. This patch fixes this issue by populating proper values to the struct

[PATCH v2 1/4] dmaengine: xilinx_dma: populate dma caps properly

2018-01-02 Thread Kedareswara rao Appana
When client driver uses dma_get_slave_caps() api, it checks for certain fields of dma_device struct currently driver is not settings the directions and addr_widths fields resulting dma_get_slave_caps() returning failure. This patch fixes this issue by populating proper values to the struct