Re: [PATCH v2 1/4] fs/posix_acl: apply umask if superblock disables ACL support

2019-08-20 Thread J. Bruce Fields
What happened to these patches? All four make sense to me, for what it's worth; feel free to add a Reviewed-by: J. Bruce Fields --b. On Sat, Jul 13, 2019 at 06:11:57AM +0200, Max Kellermann wrote: > The function posix_acl_create() applies the umask only if the inode > has no ACL (=

[PATCH v2 1/4] fs/posix_acl: apply umask if superblock disables ACL support

2019-07-12 Thread Max Kellermann
The function posix_acl_create() applies the umask only if the inode has no ACL (= NULL) or if ACLs are not supported by the filesystem driver (= -EOPNOTSUPP). However, this happens only after after the IS_POSIXACL() check succeeeded. If the superblock doesn't enable ACL support, umask will never