Re: [PATCH v2 1/4] i2c: tegra: implement slave mode

2015-07-20 Thread Wolfram Sang
On Fri, Apr 03, 2015 at 09:46:26PM +0200, Wolfram Sang wrote: > > +static void tegra_i2c_slave_write(struct tegra_i2c_dev *i2c_dev, u32 val) > > +{ > > + i2c_writel(i2c_dev, val, I2C_SL_RCVD); > > + > > + /* > > +* TODO: A correct fix needs to be found for this. > > +* > > +* We

Re: [PATCH v2 1/4] i2c: tegra: implement slave mode

2015-07-20 Thread Wolfram Sang
On Fri, Apr 03, 2015 at 09:46:26PM +0200, Wolfram Sang wrote: +static void tegra_i2c_slave_write(struct tegra_i2c_dev *i2c_dev, u32 val) +{ + i2c_writel(i2c_dev, val, I2C_SL_RCVD); + + /* +* TODO: A correct fix needs to be found for this. +* +* We experience less

Re: [PATCH v2 1/4] i2c: tegra: implement slave mode

2015-04-03 Thread Wolfram Sang
> +static void tegra_i2c_slave_write(struct tegra_i2c_dev *i2c_dev, u32 val) > +{ > + i2c_writel(i2c_dev, val, I2C_SL_RCVD); > + > + /* > + * TODO: A correct fix needs to be found for this. > + * > + * We experience less incomplete messages with this delay than without > +

Re: [PATCH v2 1/4] i2c: tegra: implement slave mode

2015-04-03 Thread Wolfram Sang
+static void tegra_i2c_slave_write(struct tegra_i2c_dev *i2c_dev, u32 val) +{ + i2c_writel(i2c_dev, val, I2C_SL_RCVD); + + /* + * TODO: A correct fix needs to be found for this. + * + * We experience less incomplete messages with this delay than without + * it,

[PATCH v2 1/4] i2c: tegra: implement slave mode

2015-03-30 Thread Andrey Danin
Initialization code is based on NVEC driver. There is a HW bug in AP20 that was also mentioned in kernel sources for Toshiba AC100. Signed-off-by: Andrey Danin --- Changes for v2: - remove hack from tegra_i2c_clock_disable - replace slave status helper functions with local variables - add

[PATCH v2 1/4] i2c: tegra: implement slave mode

2015-03-30 Thread Andrey Danin
Initialization code is based on NVEC driver. There is a HW bug in AP20 that was also mentioned in kernel sources for Toshiba AC100. Signed-off-by: Andrey Danin danind...@mail.ru --- Changes for v2: - remove hack from tegra_i2c_clock_disable - replace slave status helper functions with local