Re: [PATCH v2 1/4] libnvdimm: Fix memory leaks in of_pmem.c

2020-08-19 Thread Leizhen (ThunderTown)
On 8/19/2020 9:35 PM, Oliver O'Halloran wrote: > On Wed, Aug 19, 2020 at 10:28 PM Markus Elfring wrote: >> >>> The memory priv->bus_desc.provider_name allocated by kstrdup() is not >>> freed correctly. > > Personally I thought his commit message was perfectly fine. A little > unorthodox, but

Re: [PATCH v2 1/4] libnvdimm: Fix memory leaks in of_pmem.c

2020-08-19 Thread Oliver O'Halloran
On Wed, Aug 19, 2020 at 10:28 PM Markus Elfring wrote: > > > The memory priv->bus_desc.provider_name allocated by kstrdup() is not > > freed correctly. Personally I thought his commit message was perfectly fine. A little unorthodox, but it works. > How do you think about to choose an imperative

Re: [PATCH v2 1/4] libnvdimm: Fix memory leaks in of_pmem.c

2020-08-19 Thread Leizhen (ThunderTown)
On 8/19/2020 8:28 PM, Markus Elfring wrote: >> The memory priv->bus_desc.provider_name allocated by kstrdup() is not >> freed correctly. > > How do you think about to choose an imperative wording for > a corresponding change description? >