On Mon, Aug 5, 2013 at 9:09 AM, Kim, Milo wrote:
> In the meantime, I've reviewed the pin control subsystem,
> I think it is not the best way to implement LP3943 driver.
> The GPIO controller is OK, but I can't make flexible pin assignment for the
> PWM
> operation.
> For example, multiple outpu
> > > > Although, I think the 0 = 1, 1 = 2 ... stuff is really confusing. Is
> > > > there nothing we can do about that?
> > >
> > > OK, enum value of lp3943_pwm_output can be changed as below because
> > > LP3943_PWM_INVALID is not used anymore.
> > >
> > > enum lp3943_pwm_output {
> > > LP3943_
> > > Although, I think the 0 = 1, 1 = 2 ... stuff is really confusing. Is
> > > there nothing we can do about that?
> >
> > OK, enum value of lp3943_pwm_output can be changed as below because
> > LP3943_PWM_INVALID is not used anymore.
> >
> > enum lp3943_pwm_output {
> > LP3943_PWM_OUT0,
> >
On Wed, 31 Jul 2013, Kim, Milo wrote:
> Thanks for the review, please see my comments.
>
> > * looks good up to me up to here *
> >
> > Although, I think the 0 = 1, 1 = 2 ... stuff is really confusing. Is
> > there nothing we can do about that?
>
> OK, enum value of lp3943_pwm_output can be ch
Thanks for the review, please see my comments.
> * looks good up to me up to here *
>
> Although, I think the 0 = 1, 1 = 2 ... stuff is really confusing. Is
> there nothing we can do about that?
OK, enum value of lp3943_pwm_output can be changed as below
because LP3943_PWM_INVALID is not used a
> Cc: Lee Jones
> Cc: Linus Walleij
> Cc: Mark Brown
> Cc: Samuel Ortiz
> Cc: Thierry Reding
> Signed-off-by: Milo Kim
> ---
> drivers/mfd/Kconfig| 11 +++
> drivers/mfd/Makefile |1 +
> drivers/mfd/lp3943.c | 165
>
>
LP3943 has 16 output pins which can be used as GPIO expander and PWM generator.
* Why do we need GPIO and PWM drivers instead of LED driver?
To support LED control and general usage, GPIO and PWM drivers are necessary.
According to the datasheet(1), it's just a LED driver which has 16 channel
7 matches
Mail list logo
