Re: [PATCH v2 1/4] mm/sparse: Clean up the obsolete code comment

2019-03-26 Thread Chao Fan
On Tue, Mar 26, 2019 at 05:43:48PM +0800, Baoquan He wrote: >On 03/26/19 at 05:36pm, Chao Fan wrote: >> On Tue, Mar 26, 2019 at 05:30:57PM +0800, Baoquan He wrote: >> >On 03/26/19 at 10:23am, Michal Hocko wrote: >> >> On Tue 26-03-19 17:02:24, Baoquan He wrote: >> >> > The code comment above sparse

Re: [PATCH v2 1/4] mm/sparse: Clean up the obsolete code comment

2019-03-26 Thread Baoquan He
On 03/26/19 at 05:36pm, Chao Fan wrote: > On Tue, Mar 26, 2019 at 05:30:57PM +0800, Baoquan He wrote: > >On 03/26/19 at 10:23am, Michal Hocko wrote: > >> On Tue 26-03-19 17:02:24, Baoquan He wrote: > >> > The code comment above sparse_add_one_section() is obsolete and > >> > incorrect, clean it up

Re: [PATCH v2 1/4] mm/sparse: Clean up the obsolete code comment

2019-03-26 Thread Chao Fan
On Tue, Mar 26, 2019 at 05:30:57PM +0800, Baoquan He wrote: >On 03/26/19 at 10:23am, Michal Hocko wrote: >> On Tue 26-03-19 17:02:24, Baoquan He wrote: >> > The code comment above sparse_add_one_section() is obsolete and >> > incorrect, clean it up and write new one. >> > >> > Signed-off-by: Baoqu

Re: [PATCH v2 1/4] mm/sparse: Clean up the obsolete code comment

2019-03-26 Thread Baoquan He
On 03/26/19 at 10:23am, Michal Hocko wrote: > On Tue 26-03-19 17:02:24, Baoquan He wrote: > > The code comment above sparse_add_one_section() is obsolete and > > incorrect, clean it up and write new one. > > > > Signed-off-by: Baoquan He > > Please note that you need /** to start a kernel doc. O

Re: [PATCH v2 1/4] mm/sparse: Clean up the obsolete code comment

2019-03-26 Thread Michal Hocko
On Tue 26-03-19 17:02:24, Baoquan He wrote: > The code comment above sparse_add_one_section() is obsolete and > incorrect, clean it up and write new one. > > Signed-off-by: Baoquan He Please note that you need /** to start a kernel doc. Other than that. Acked-by: Michal Hocko > --- > v1-v2: >

Re: [PATCH v2 1/4] mm/sparse: Clean up the obsolete code comment

2019-03-26 Thread Mike Rapoport
On Tue, Mar 26, 2019 at 05:02:24PM +0800, Baoquan He wrote: > The code comment above sparse_add_one_section() is obsolete and > incorrect, clean it up and write new one. > > Signed-off-by: Baoquan He Reviewed-by: Mike Rapoport > --- > v1-v2: > Add comments to explain what the returned value

[PATCH v2 1/4] mm/sparse: Clean up the obsolete code comment

2019-03-26 Thread Baoquan He
The code comment above sparse_add_one_section() is obsolete and incorrect, clean it up and write new one. Signed-off-by: Baoquan He --- v1-v2: Add comments to explain what the returned value means for each error code. mm/sparse.c | 15 --- 1 file changed, 12 insertions(+), 3 del