Re: [PATCH v2 1/4] perf tools: Fix segfault for symbol annotation on TUI

2015-01-17 Thread Arnaldo Carvalho de Melo
Em Thu, Jan 15, 2015 at 09:20:21AM +0900, Namhyung Kim escreveu: > On Wed, Jan 14, 2015 at 06:08:52PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Wed, Jan 14, 2015 at 07:57:49AM -0700, David Ahern escreveu: > > > On 1/14/15 4:18 AM, Namhyung Kim wrote: > > > > static inline struct annotation *sy

Re: [PATCH v2 1/4] perf tools: Fix segfault for symbol annotation on TUI

2015-01-14 Thread Namhyung Kim
Hi Arnaldo and David, On Wed, Jan 14, 2015 at 06:08:52PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Jan 14, 2015 at 07:57:49AM -0700, David Ahern escreveu: > > On 1/14/15 4:18 AM, Namhyung Kim wrote: > > > > >@@ -129,8 +124,7 @@ static inline struct sym_hist > > >*annotation__histogram(str

Re: [PATCH v2 1/4] perf tools: Fix segfault for symbol annotation on TUI

2015-01-14 Thread Arnaldo Carvalho de Melo
Em Wed, Jan 14, 2015 at 07:57:49AM -0700, David Ahern escreveu: > On 1/14/15 4:18 AM, Namhyung Kim wrote: > > >@@ -129,8 +124,7 @@ static inline struct sym_hist > >*annotation__histogram(struct annotation *notes, i > > > > static inline struct annotation *symbol__annotation(struct symbol *sym) >

Re: [PATCH v2 1/4] perf tools: Fix segfault for symbol annotation on TUI

2015-01-14 Thread David Ahern
On 1/14/15 4:18 AM, Namhyung Kim wrote: @@ -129,8 +124,7 @@ static inline struct sym_hist *annotation__histogram(struct annotation *notes, i static inline struct annotation *symbol__annotation(struct symbol *sym) { - struct sannotation *a = container_of(sym, struct sannotation, symbo

Re: [PATCH v2 1/4] perf tools: Fix segfault for symbol annotation on TUI

2015-01-14 Thread Arnaldo Carvalho de Melo
Em Wed, Jan 14, 2015 at 08:18:05PM +0900, Namhyung Kim escreveu: > Currently the symbol structure is allocated with symbol_conf.priv_size > to carry sideband information like annotation, map browser on TUI and > sort-by-name tree node. So retrieving these information from symbol > needs to care ab

[PATCH v2 1/4] perf tools: Fix segfault for symbol annotation on TUI

2015-01-14 Thread Namhyung Kim
Currently the symbol structure is allocated with symbol_conf.priv_size to carry sideband information like annotation, map browser on TUI and sort-by-name tree node. So retrieving these information from symbol needs to care about the details of such placement. However the annotation code just assu