Re: [PATCH v2 1/4] platform/x86: intel_pmc_core: Show Latency Tolerance info

2018-10-30 Thread Srinivas Pandruvada
On Tue, 2018-10-30 at 20:33 +0200, Andy Shevchenko wrote: > On Tue, Oct 30, 2018 at 8:03 PM Srinivas Pandruvada > wrote: > > > > > Index printing is required here (for LTR Show and LTR Ignore) > > > > because it > > > > paves an obvious and easy way for the users of this driver to > > > > know >

Re: [PATCH v2 1/4] platform/x86: intel_pmc_core: Show Latency Tolerance info

2018-10-30 Thread Srinivas Pandruvada
On Tue, 2018-10-30 at 20:33 +0200, Andy Shevchenko wrote: > On Tue, Oct 30, 2018 at 8:03 PM Srinivas Pandruvada > wrote: > > > > > Index printing is required here (for LTR Show and LTR Ignore) > > > > because it > > > > paves an obvious and easy way for the users of this driver to > > > > know >

Re: [PATCH v2 1/4] platform/x86: intel_pmc_core: Show Latency Tolerance info

2018-10-30 Thread Andy Shevchenko
On Tue, Oct 30, 2018 at 8:03 PM Srinivas Pandruvada wrote: > > > Index printing is required here (for LTR Show and LTR Ignore) > > > because it > > > paves an obvious and easy way for the users of this driver to know > > > the > > > IP number to be used for LTR ignore. This was specifically > >

Re: [PATCH v2 1/4] platform/x86: intel_pmc_core: Show Latency Tolerance info

2018-10-30 Thread Andy Shevchenko
On Tue, Oct 30, 2018 at 8:03 PM Srinivas Pandruvada wrote: > > > Index printing is required here (for LTR Show and LTR Ignore) > > > because it > > > paves an obvious and easy way for the users of this driver to know > > > the > > > IP number to be used for LTR ignore. This was specifically > >

Re: [PATCH v2 1/4] platform/x86: intel_pmc_core: Show Latency Tolerance info

2018-10-30 Thread Srinivas Pandruvada
[...] > > > For example, index printing. Please, remove it. I completely > > > forgot > > > about userspace powerful tools. At least two very old and nice > > > can > > > enumerate lines for you. > > > Obviously the index printing is redundant. > > > > Index printing is required here (for LTR

Re: [PATCH v2 1/4] platform/x86: intel_pmc_core: Show Latency Tolerance info

2018-10-30 Thread Srinivas Pandruvada
[...] > > > For example, index printing. Please, remove it. I completely > > > forgot > > > about userspace powerful tools. At least two very old and nice > > > can > > > enumerate lines for you. > > > Obviously the index printing is redundant. > > > > Index printing is required here (for LTR

Re: [PATCH v2 1/4] platform/x86: intel_pmc_core: Show Latency Tolerance info

2018-10-30 Thread Andy Shevchenko
On Tue, Oct 30, 2018 at 9:25 AM Bhardwaj, Rajneesh wrote: > > + Srinivas > > > On 19-Oct-18 5:42 PM, Andy Shevchenko wrote: > > On Sat, Oct 6, 2018 at 9:54 AM Rajneesh Bhardwaj > > wrote: > >> This adds support to show the Latency Tolerance Reporting for the IPs on > >> the PCH as reported by

Re: [PATCH v2 1/4] platform/x86: intel_pmc_core: Show Latency Tolerance info

2018-10-30 Thread Andy Shevchenko
On Tue, Oct 30, 2018 at 9:25 AM Bhardwaj, Rajneesh wrote: > > + Srinivas > > > On 19-Oct-18 5:42 PM, Andy Shevchenko wrote: > > On Sat, Oct 6, 2018 at 9:54 AM Rajneesh Bhardwaj > > wrote: > >> This adds support to show the Latency Tolerance Reporting for the IPs on > >> the PCH as reported by

Re: [PATCH v2 1/4] platform/x86: intel_pmc_core: Show Latency Tolerance info

2018-10-30 Thread Bhardwaj, Rajneesh
+ Srinivas On 19-Oct-18 5:42 PM, Andy Shevchenko wrote: On Sat, Oct 6, 2018 at 9:54 AM Rajneesh Bhardwaj wrote: This adds support to show the Latency Tolerance Reporting for the IPs on the PCH as reported by the PMC. The format shown here is raw LTR data payload that can further be decoded

Re: [PATCH v2 1/4] platform/x86: intel_pmc_core: Show Latency Tolerance info

2018-10-30 Thread Bhardwaj, Rajneesh
+ Srinivas On 19-Oct-18 5:42 PM, Andy Shevchenko wrote: On Sat, Oct 6, 2018 at 9:54 AM Rajneesh Bhardwaj wrote: This adds support to show the Latency Tolerance Reporting for the IPs on the PCH as reported by the PMC. The format shown here is raw LTR data payload that can further be decoded

Re: [PATCH v2 1/4] platform/x86: intel_pmc_core: Show Latency Tolerance info

2018-10-19 Thread Andy Shevchenko
On Sat, Oct 6, 2018 at 9:54 AM Rajneesh Bhardwaj wrote: > > This adds support to show the Latency Tolerance Reporting for the IPs on > the PCH as reported by the PMC. The format shown here is raw LTR data > payload that can further be decoded as per the PCI specification. > > This also fixes some

Re: [PATCH v2 1/4] platform/x86: intel_pmc_core: Show Latency Tolerance info

2018-10-19 Thread Andy Shevchenko
On Sat, Oct 6, 2018 at 9:54 AM Rajneesh Bhardwaj wrote: > > This adds support to show the Latency Tolerance Reporting for the IPs on > the PCH as reported by the PMC. The format shown here is raw LTR data > payload that can further be decoded as per the PCI specification. > > This also fixes some

[PATCH v2 1/4] platform/x86: intel_pmc_core: Show Latency Tolerance info

2018-10-06 Thread Rajneesh Bhardwaj
This adds support to show the Latency Tolerance Reporting for the IPs on the PCH as reported by the PMC. The format shown here is raw LTR data payload that can further be decoded as per the PCI specification. This also fixes some minor alignment issues in the header file by removing spaces and

[PATCH v2 1/4] platform/x86: intel_pmc_core: Show Latency Tolerance info

2018-10-06 Thread Rajneesh Bhardwaj
This adds support to show the Latency Tolerance Reporting for the IPs on the PCH as reported by the PMC. The format shown here is raw LTR data payload that can further be decoded as per the PCI specification. This also fixes some minor alignment issues in the header file by removing spaces and