Re: [PATCH v2 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-26 Thread Hans de Goede
Hi, On 3/26/21 10:55 AM, Henning Schild wrote: > Am Thu, 18 Mar 2021 12:45:01 +0100 > schrieb Hans de Goede : > >> Hi, >> >> On 3/18/21 12:30 PM, Enrico Weigelt, metux IT consult wrote: >>> On 17.03.21 21:03, Hans de Goede wrote: >>> >>> Hi, >>> > It just identifies the box and tells

Re: [PATCH v2 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-26 Thread Henning Schild
Am Thu, 18 Mar 2021 12:45:01 +0100 schrieb Hans de Goede : > Hi, > > On 3/18/21 12:30 PM, Enrico Weigelt, metux IT consult wrote: > > On 17.03.21 21:03, Hans de Goede wrote: > > > > Hi, > > > >>> It just identifies the box and tells subsequent drivers which one > >>> it is, which watchdog

Re: [PATCH v2 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-18 Thread Hans de Goede
Hi, On 3/18/21 12:30 PM, Enrico Weigelt, metux IT consult wrote: > On 17.03.21 21:03, Hans de Goede wrote: > > Hi, > >>> It just identifies the box and tells subsequent drivers which one it >>> is, which watchdog and LED path to take. Moving the knowledge of which >>> box has which LED/watchdog

Re: [PATCH v2 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-18 Thread Enrico Weigelt, metux IT consult
On 17.03.21 21:03, Hans de Goede wrote: Hi, It just identifies the box and tells subsequent drivers which one it is, which watchdog and LED path to take. Moving the knowledge of which box has which LED/watchdog into the respective drivers seems to be the better way to go. So we would end up

Re: [PATCH v2 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-17 Thread Hans de Goede
Hi, On 3/17/21 8:13 PM, Henning Schild wrote: > Am Mon, 15 Mar 2021 12:31:11 +0200 > schrieb Andy Shevchenko : > >> On Mon, Mar 15, 2021 at 12:02 PM Henning Schild >> wrote: >>> >>> This mainly implements detection of these devices and will allow >>> secondary drivers to work on such machines.

Re: [PATCH v2 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-17 Thread Henning Schild
Am Mon, 15 Mar 2021 12:31:11 +0200 schrieb Andy Shevchenko : > On Mon, Mar 15, 2021 at 12:02 PM Henning Schild > wrote: > > > > This mainly implements detection of these devices and will allow > > secondary drivers to work on such machines. > > > > The identification is DMI-based with a vendor

Re: [PATCH v2 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-15 Thread Henning Schild
Am Mon, 15 Mar 2021 12:31:11 +0200 schrieb Andy Shevchenko : > On Mon, Mar 15, 2021 at 12:02 PM Henning Schild > wrote: > > > > This mainly implements detection of these devices and will allow > > secondary drivers to work on such machines. > > > > The identification is DMI-based with a vendor

Re: [PATCH v2 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-15 Thread Andy Shevchenko
On Mon, Mar 15, 2021 at 12:02 PM Henning Schild wrote: > > This mainly implements detection of these devices and will allow > secondary drivers to work on such machines. > > The identification is DMI-based with a vendor specific way to tell them > apart in a reliable way. > > Drivers for LEDs and

[PATCH v2 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-15 Thread Henning Schild
This mainly implements detection of these devices and will allow secondary drivers to work on such machines. The identification is DMI-based with a vendor specific way to tell them apart in a reliable way. Drivers for LEDs and Watchdogs will follow to make use of that platform detection.