Re: [PATCH v2 1/4] spi: rockchip: fix error handling when probe

On Tue, Jun 13, 2017 at 01:25:40PM +0800, Jeffy Chen wrote: > After failed to request dma tx chain, we need to disable pm_runtime. > Also cleanup error labels for better readability. > > Signed-off-by: Jeffy Chen > --- > > Changes in v2: None Looks good to me. I

Re: [PATCH v2 1/4] spi: rockchip: fix error handling when probe

On Tue, Jun 13, 2017 at 01:25:40PM +0800, Jeffy Chen wrote: > After failed to request dma tx chain, we need to disable pm_runtime. > Also cleanup error labels for better readability. > > Signed-off-by: Jeffy Chen > --- > > Changes in v2: None Looks good to me. I guess the original code was

[PATCH v2 1/4] spi: rockchip: fix error handling when probe

After failed to request dma tx chain, we need to disable pm_runtime. Also cleanup error labels for better readability. Signed-off-by: Jeffy Chen --- Changes in v2: None drivers/spi/spi-rockchip.c | 27 ++- 1 file changed, 14 insertions(+), 13

[PATCH v2 1/4] spi: rockchip: fix error handling when probe

After failed to request dma tx chain, we need to disable pm_runtime. Also cleanup error labels for better readability. Signed-off-by: Jeffy Chen --- Changes in v2: None drivers/spi/spi-rockchip.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git