Re: [PATCH v2 1/4] spi: spidev: Restore all SPI mode flags on ioctl failure

2014-02-27 Thread Geert Uytterhoeven
Hi Mark, On Thu, Feb 27, 2014 at 5:50 AM, Mark Brown wrote: > > In commit f477b7fb13df2b843997559ff34e87d054ba6538 ("spi: DUAL and QUAD > > support"), spi_device.mode was enlarged from 8 to 16 bits. > > Applied, thanks. Thanks a lot! >> For SPI_IOC_WR_MODE this is probably not so important, as

Re: [PATCH v2 1/4] spi: spidev: Restore all SPI mode flags on ioctl failure

2014-02-26 Thread Mark Brown
On Tue, Feb 25, 2014 at 11:40:16AM +0100, Geert Uytterhoeven wrote: > From: Geert Uytterhoeven > > In commit f477b7fb13df2b843997559ff34e87d054ba6538 ("spi: DUAL and QUAD > support"), spi_device.mode was enlarged from 8 to 16 bits. Applied, thanks. > For SPI_IOC_WR_MODE this is probably not so

[PATCH v2 1/4] spi: spidev: Restore all SPI mode flags on ioctl failure

2014-02-25 Thread Geert Uytterhoeven
From: Geert Uytterhoeven In commit f477b7fb13df2b843997559ff34e87d054ba6538 ("spi: DUAL and QUAD support"), spi_device.mode was enlarged from 8 to 16 bits. However, the spidev code still only saved 8 bits of data. If a spidev SPI_IOC_WR_MODE or SPI_IOC_WR_LSB_FIRST request failed, only the lower