Re: [PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver

2016-11-23 Thread Frank Rowand
On 11/23/16 10:13, Frank Rowand wrote: > On 11/22/16 21:55, Sekhar Nori wrote: >> On Tuesday 22 November 2016 11:51 PM, Frank Rowand wrote: >>> Please note that the compatible property might contain several strings, not >>> just >>> a single string. >> >> So I guess the best thing to do is to use

Re: [PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver

2016-11-23 Thread Frank Rowand
On 11/22/16 21:55, Sekhar Nori wrote: > On Tuesday 22 November 2016 11:51 PM, Frank Rowand wrote: >> Please note that the compatible property might contain several strings, not >> just >> a single string. > > So I guess the best thing to do is to use > of_property_read_string_index() and print th

Re: [PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver

2016-11-23 Thread Sudeep Holla
On 22/11/16 01:43, Frank Rowand wrote: Hi Sekhar, (And adding Sudeep since he becomes involved in this further down thread and at that point says he will re-work this proposed work around in a manner that is incorrect in a manner that is similar to this proposed work around.) On 11/21/16 08:3

Re: [PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver

2016-11-22 Thread Sekhar Nori
On Tuesday 22 November 2016 11:51 PM, Frank Rowand wrote: > Please note that the compatible property might contain several strings, not > just > a single string. So I guess the best thing to do is to use of_property_read_string_index() and print the sting at index 0. Thanks, Sekhar

Re: [PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver

2016-11-22 Thread Frank Rowand
On 11/21/16 22:25, Sekhar Nori wrote: > Hi Frank, > > On Tuesday 22 November 2016 07:13 AM, Frank Rowand wrote: >> On 11/21/16 08:33, Sekhar Nori wrote: >>> On Monday 31 October 2016 08:15 PM, Bartosz Golaszewski wrote: +static int da8xx_ddrctl_probe(struct platform_device *pdev) +{

Re: [PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver

2016-11-21 Thread Sekhar Nori
Hi Frank, On Tuesday 22 November 2016 07:13 AM, Frank Rowand wrote: > On 11/21/16 08:33, Sekhar Nori wrote: >> On Monday 31 October 2016 08:15 PM, Bartosz Golaszewski wrote: >>> +static int da8xx_ddrctl_probe(struct platform_device *pdev) >>> +{ >>> + const struct da8xx_ddrctl_config_knob *knob;

Re: [PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver

2016-11-21 Thread Frank Rowand
Hi Sekhar, (And adding Sudeep since he becomes involved in this further down thread and at that point says he will re-work this proposed work around in a manner that is incorrect in a manner that is similar to this proposed work around.) On 11/21/16 08:33, Sekhar Nori wrote: > On Monday 31 Octobe

Re: [PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver

2016-11-21 Thread Sudeep Holla
Hi Robin, On 21/11/16 17:47, Robin Murphy wrote: Hi Bartosz, Sekhar, On 21/11/16 16:48, Bartosz Golaszewski wrote: [...] Hi Sekhar, thanks for spotting that. I think we should introduce this function right away, rather than having two static functions doing the same thing. If you don't mi

Re: [PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver

2016-11-21 Thread Robin Murphy
Hi Bartosz, Sekhar, On 21/11/16 16:48, Bartosz Golaszewski wrote: > 2016-11-21 17:33 GMT+01:00 Sekhar Nori : >> On Monday 31 October 2016 08:15 PM, Bartosz Golaszewski wrote: >>> +static int da8xx_ddrctl_probe(struct platform_device *pdev) >>> +{ >>> + const struct da8xx_ddrctl_config_knob *kn

Re: [PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver

2016-11-21 Thread Bartosz Golaszewski
2016-11-21 17:33 GMT+01:00 Sekhar Nori : > On Monday 31 October 2016 08:15 PM, Bartosz Golaszewski wrote: >> +static int da8xx_ddrctl_probe(struct platform_device *pdev) >> +{ >> + const struct da8xx_ddrctl_config_knob *knob; >> + const struct da8xx_ddrctl_setting *setting; >> + struct

Re: [PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver

2016-11-21 Thread Sekhar Nori
On Monday 31 October 2016 08:15 PM, Bartosz Golaszewski wrote: > +static int da8xx_ddrctl_probe(struct platform_device *pdev) > +{ > + const struct da8xx_ddrctl_config_knob *knob; > + const struct da8xx_ddrctl_setting *setting; > + struct device_node *node; > + struct resource *res;

Re: [PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver

2016-11-11 Thread Sekhar Nori
On Wednesday 09 November 2016 11:54 PM, Rob Herring wrote: > On Mon, Oct 31, 2016 at 03:45:34PM +0100, Bartosz Golaszewski wrote: >> Create a new driver for the da8xx DDR2/mDDR controller and implement >> support for writing to the Peripheral Bus Burst Priority Register. >> >> Signed-off-by: Bartos

Re: [PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver

2016-11-09 Thread Rob Herring
On Mon, Oct 31, 2016 at 03:45:34PM +0100, Bartosz Golaszewski wrote: > Create a new driver for the da8xx DDR2/mDDR controller and implement > support for writing to the Peripheral Bus Burst Priority Register. > > Signed-off-by: Bartosz Golaszewski > --- > .../memory-controllers/ti-da8xx-ddrctl.t

Re: [PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver

2016-11-04 Thread Kevin Hilman
Bartosz Golaszewski writes: > Create a new driver for the da8xx DDR2/mDDR controller and implement > support for writing to the Peripheral Bus Burst Priority Register. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Kevin Hilman

Re: [PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver

2016-11-01 Thread Sekhar Nori
On Monday 31 October 2016 08:15 PM, Bartosz Golaszewski wrote: > Create a new driver for the da8xx DDR2/mDDR controller and implement > support for writing to the Peripheral Bus Burst Priority Register. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Sekhar Nori Thanks, Sekhar

[PATCH v2 1/5] ARM: memory: da8xx-ddrctl: new driver

2016-10-31 Thread Bartosz Golaszewski
Create a new driver for the da8xx DDR2/mDDR controller and implement support for writing to the Peripheral Bus Burst Priority Register. Signed-off-by: Bartosz Golaszewski --- .../memory-controllers/ti-da8xx-ddrctl.txt | 20 +++ drivers/memory/Kconfig | 8 +