Re: [PATCH v2 1/5] dt-bindings: ARM: Mediatek: Document bindings for MT8192

2020-08-11 Thread Weiyi Lu
On Wed, 2020-07-29 at 11:53 +0200, Enric Balletbo Serra wrote: > Hi Weiyu, > > Thanks for the patch, some comments below. I am not sure what > maintainers think but your patches, in general, are really big and I'm > wondering if wouldn't be better split by functionalities. Will make > your series

Re: [PATCH v2 1/5] dt-bindings: ARM: Mediatek: Document bindings for MT8192

2020-07-29 Thread Enric Balletbo Serra
Hi Weiyu, Thanks for the patch, some comments below. I am not sure what maintainers think but your patches, in general, are really big and I'm wondering if wouldn't be better split by functionalities. Will make your series much longer but easy to review in my opinion. Anyway, I'm going to comment

[PATCH v2 1/5] dt-bindings: ARM: Mediatek: Document bindings for MT8192

2020-07-29 Thread Weiyi Lu
This patch adds the binding documentation for apmixedsys, audsys, camsys-raw, camsys, imgsys, imp_iic_wrap, infracfg, ipesys, mdpsys, mfgcfg, mmsys, msdc, pericfg, scp-adsp, topckgen, vdecsys-soc, vdecsys and vencsys for Mediatek MT8192. Signed-off-by: Weiyi Lu --- .../bindings/arm/mediatek/medi