Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-14 Thread Namjae Jeon
2012/9/14, OGAWA Hirofumi : > "J. Bruce Fields" writes: > >>> > Current -mm means the best-effort work only if inode cache is not >>> > evicted. I.e. if there is no inode cache anymore on server, server >>> > would return ESTALE. So I guess the behavior would not be stable >>> > relatively. >>> H

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-13 Thread OGAWA Hirofumi
"J. Bruce Fields" writes: >> > Current -mm means the best-effort work only if inode cache is not >> > evicted. I.e. if there is no inode cache anymore on server, server >> > would return ESTALE. So I guess the behavior would not be stable >> > relatively. >> Hi OGAWA. >> Sorry for late response.

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-13 Thread J. Bruce Fields
On Thu, Sep 13, 2012 at 11:24:30PM +0900, Namjae Jeon wrote: > 2012/9/13, OGAWA Hirofumi : > > "J. Bruce Fields" writes: > > > >>> >> Grepping around... Documentation/sysctl/vm.txt mentions a > >>> >> vfs_cache_pressure parameter. > >>> >> Yeah. And dirty hack will be possible to adjust sb->s_shri

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-13 Thread Namjae Jeon
2012/9/13, OGAWA Hirofumi : > "J. Bruce Fields" writes: > >>> >> Grepping around... Documentation/sysctl/vm.txt mentions a >>> >> vfs_cache_pressure parameter. >>> >> Yeah. And dirty hack will be possible to adjust sb->s_shrink.batch. >>> > I am worrying if it could lead to OOM condition on embedd

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-13 Thread OGAWA Hirofumi
"J. Bruce Fields" writes: >> >> Grepping around... Documentation/sysctl/vm.txt mentions a >> >> vfs_cache_pressure parameter. >> >> Yeah. And dirty hack will be possible to adjust sb->s_shrink.batch. >> > I am worrying if it could lead to OOM condition on embedded >> > system(short memory(DRAM) a

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-13 Thread J. Bruce Fields
On Thu, Sep 13, 2012 at 05:33:02PM +0900, OGAWA Hirofumi wrote: > Namjae Jeon writes: > > >> I see. So, client can't solve the ESTALE if inode cache was evicted, > >> right? (without application changes) > > > > There can be situation where we may get not only ESTALE but EIO also. > > > > For exa

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-13 Thread OGAWA Hirofumi
Namjae Jeon writes: >> I see. So, client can't solve the ESTALE if inode cache was evicted, >> right? (without application changes) > > There can be situation where we may get not only ESTALE but EIO also. > > For example, > --- > fd = open(“foo.txt”); > while (1) { >

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-13 Thread Namjae Jeon
> >> -> ESTALE will be returned -> discard old FH -> restart from LOOKUP -> > >> make cached inode -> use returned new FH. > >> > >> Yeah, I know this is unstable (there is no perfect solution for now), > > > > You may end up with a totally different file, of course: > > > > client:

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-12 Thread OGAWA Hirofumi
"J. Bruce Fields" writes: > As another server-side workaround: maybe they could try tuning the inode > caching to make eviction less likely? > > Grepping around... Documentation/sysctl/vm.txt mentions a > vfs_cache_pressure parameter. Yeah. And dirty hack will be possible to adjust sb->s_shrink

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-12 Thread J. Bruce Fields
On Thu, Sep 13, 2012 at 02:38:11AM +0900, OGAWA Hirofumi wrote: > "J. Bruce Fields" writes: > > >> On other view (as server side solution), we are thinking there is > >> possible to make the stable filehandle on FAT if we disabled some > >> operations (e.g. rename(), unlink()) which change inode

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-12 Thread OGAWA Hirofumi
"J. Bruce Fields" writes: >> On other view (as server side solution), we are thinking there is >> possible to make the stable filehandle on FAT if we disabled some >> operations (e.g. rename(), unlink()) which change inode location in FAT. >> >> Yes, it would be stable, but supporting limited op

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-12 Thread J. Bruce Fields
On Thu, Sep 13, 2012 at 02:03:51AM +0900, OGAWA Hirofumi wrote: > "J. Bruce Fields" writes: > > >> > Supposing, the server/client state is after cold boot, and client try to > >> > rename at first without any cache on client/server. > >> > > >> > Even if this state, does the server return ESTALE?

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-12 Thread OGAWA Hirofumi
"J. Bruce Fields" writes: >> > Supposing, the server/client state is after cold boot, and client try to >> > rename at first without any cache on client/server. >> > >> > Even if this state, does the server return ESTALE? If it doesn't return >> > ESTALE, I can't understand why it is really unfix

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-12 Thread J. Bruce Fields
On Wed, Sep 12, 2012 at 11:12:56PM +0900, Namjae Jeon wrote: > 2012/9/12 OGAWA Hirofumi : > > Namjae Jeon writes: > > > I think that it is unfixable because we can not know i_pos of inode > changed by rename. > And even though we know it, there is no rebuild inode routine in -mm. >

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-12 Thread Namjae Jeon
2012/9/12 OGAWA Hirofumi : > Namjae Jeon writes: > I think that it is unfixable because we can not know i_pos of inode changed by rename. And even though we know it, there is no rebuild inode routine in -mm. And It even can not fix in our patches. >>> > And are you tried ht

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-11 Thread OGAWA Hirofumi
Namjae Jeon writes: >>> I think that it is unfixable because we can not know i_pos of inode >>> changed by rename. >>> And even though we know it, there is no rebuild inode routine in -mm. >>> And It even can not fix in our patches. >> And are you tried https://lkml.org/lkml/2012/6/29/381 pa

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-11 Thread Namjae Jeon
2012/9/11 OGAWA Hirofumi : > Namjae Jeon writes: > >>> Since rename() will be disabled on stable ino patches, this will be >>> unfixable, so rather maybe it is worse. >> Currently with our patchset : only rename issue (could not find any >> correct approach to ignore this. If we do not update this

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-11 Thread OGAWA Hirofumi
Namjae Jeon writes: >> Since rename() will be disabled on stable ino patches, this will be >> unfixable, so rather maybe it is worse. > Currently with our patchset : only rename issue (could not find any > correct approach to ignore this. If we do not update this immediately > at i_pos change – i

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-11 Thread Namjae Jeon
2012/9/10, OGAWA Hirofumi : > Namjae Jeon writes: > >> Yes, It is true(current VFAT of -mm tree is not stable). Although we >> set lookupcache=none while mounting, ESTALE error can still occur in >> rename case. >> So there still remain ESTALE error issue from rename case on current -mm >> tree.

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-10 Thread OGAWA Hirofumi
Namjae Jeon writes: > Yes, It is true(current VFAT of -mm tree is not stable). Although we > set lookupcache=none while mounting, ESTALE error can still occur in > rename case. > So there still remain ESTALE error issue from rename case on current -mm tree. > plz See the step as the following >

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-10 Thread Steven J. Magnani
On Sun, 2012-09-09 at 18:32 +0900, OGAWA Hirofumi wrote: > What is your use case? What Neil Brown refers to as a "general file access protocol" - basically making a flash disk available to a small embedded network for random-access file I/O. The flash disk is required to interoperate with Wind

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-10 Thread Namjae Jeon
2012/9/9, OGAWA Hirofumi : > OGAWA Hirofumi writes: > >> What is your use case? I'm assuming current NFS support of FAT >> is still unstable behavior even with your patches. Is this true? Hi. OGAWA. Yes, It is true(current VFAT of -mm tree is not stable). Although we set lookupcache=none while

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-09 Thread OGAWA Hirofumi
OGAWA Hirofumi writes: > What is your use case? I'm assuming current NFS support of FAT is not > unstable behavior even with your patches. Is this true? s/is not unstable/is still unstable/ -- OGAWA Hirofumi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bod

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-09 Thread OGAWA Hirofumi
"Steven J. Magnani" writes: > On Fri, 2012-09-07 at 16:01 +0900, Namjae Jeon wrote: >> Hi. OGAWA. >> >> I checked read-only option for export on FAT. >> I think that there are 3 approaches as mentioned below. >> >> 1. As per the current scenario – user already has the option of >> setting ‘ro’

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-07 Thread Steven J. Magnani
On Fri, 2012-09-07 at 16:01 +0900, Namjae Jeon wrote: > Hi. OGAWA. > > I checked read-only option for export on FAT. > I think that there are 3 approaches as mentioned below. > > 1. As per the current scenario – user already has the option of > setting ‘ro’ in /etc/exports – so that can also be

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-07 Thread Namjae Jeon
Hi. OGAWA. I checked read-only option for export on FAT. I think that there are 3 approaches as mentioned below. 1. As per the current scenario – user already has the option of setting ‘ro’ in /etc/exports – so that can also be used to make it read-only. 2. Forcefully set to “read-only”

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-06 Thread Namjae Jeon
2012/9/6 OGAWA Hirofumi : > Namjae Jeon writes: > In this long discusstion about the FAT acceptance over NFS, our belief is still that the objective should be to reduce errors as much as possible and then if there are certain scenarios - at least that could be highlighted as a

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-06 Thread OGAWA Hirofumi
Namjae Jeon writes: >>> In this long discusstion about the FAT acceptance over NFS, our belief >>> is still that the objective should be to reduce errors as much as >>> possible and then if there are certain scenarios - at least that could >>> be highlighted as a limitation in Documentation inste

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-05 Thread Namjae Jeon
2012/9/5 OGAWA Hirofumi : > Namjae Jeon writes: > >> In this long discusstion about the FAT acceptance over NFS, our belief >> is still that the objective should be to reduce errors as much as >> possible and then if there are certain scenarios - at least that could >> be highlighted as a limitati

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-05 Thread OGAWA Hirofumi
Namjae Jeon writes: > In this long discusstion about the FAT acceptance over NFS, our belief > is still that the objective should be to reduce errors as much as > possible and then if there are certain scenarios - at least that could > be highlighted as a limitation in Documentation instead of co

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-05 Thread Namjae Jeon
2012/9/5, Al Viro : > On Wed, Sep 05, 2012 at 12:57:44AM +0900, Namjae Jeon wrote: >> From: Namjae Jeon >> >> All the files on a FAT partition have an on-disk directory entry. >> The location of these entries, i_pos, is unique and is constructed by the >> fat_make_i_pos() function.We can use this

Re: [PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-04 Thread Al Viro
On Wed, Sep 05, 2012 at 12:57:44AM +0900, Namjae Jeon wrote: > From: Namjae Jeon > > All the files on a FAT partition have an on-disk directory entry. > The location of these entries, i_pos, is unique and is constructed by the > fat_make_i_pos() function.We can use this as the inode number making

[PATCH v2 1/5] fat: allocate persistent inode numbers

2012-09-04 Thread Namjae Jeon
From: Namjae Jeon All the files on a FAT partition have an on-disk directory entry. The location of these entries, i_pos, is unique and is constructed by the fat_make_i_pos() function.We can use this as the inode number making it peristent across remounts. Signed-off-by: Namjae Jeon Signed-off-