Re: [PATCH v2 1/5] hugetlb: use page.private for hugetlb specific page flags

2021-01-20 Thread Mike Kravetz
On 1/20/21 1:30 AM, Oscar Salvador wrote: > On Tue, Jan 19, 2021 at 05:30:45PM -0800, Mike Kravetz wrote: >> + * Macros to create test, set and clear function definitions for >> + * hugetlb specific page flags. >> + */ >> +#ifdef CONFIG_HUGETLB_PAGE >> +#define TESTHPAGEFLAG(uname, flname)

Re: [PATCH v2 1/5] hugetlb: use page.private for hugetlb specific page flags

2021-01-20 Thread Oscar Salvador
On Tue, Jan 19, 2021 at 05:30:45PM -0800, Mike Kravetz wrote: > + * Macros to create test, set and clear function definitions for > + * hugetlb specific page flags. > + */ > +#ifdef CONFIG_HUGETLB_PAGE > +#define TESTHPAGEFLAG(uname, flname) \ > +static inline int

Re: [PATCH v2 1/5] hugetlb: use page.private for hugetlb specific page flags

2021-01-20 Thread kernel test robot
Hi Mike, I love your patch! Yet something to improve: [auto build test ERROR on next-20210119] [also build test ERROR on v5.11-rc4] [cannot apply to linux/master linus/master hnaz-linux-mm/master v5.11-rc4 v5.11-rc3 v5.11-rc2] [If your patch is applied to the wrong git tree, kindly drop us a

Re: [PATCH v2 1/5] hugetlb: use page.private for hugetlb specific page flags

2021-01-20 Thread Miaohe Lin
Hi: On 2021/1/20 9:30, Mike Kravetz wrote: > As hugetlbfs evolved, state information about hugetlb pages was added. > One 'convenient' way of doing this was to use available fields in tail > pages. Over time, it has become difficult to know the meaning or contents > of fields simply by looking at

[PATCH v2 1/5] hugetlb: use page.private for hugetlb specific page flags

2021-01-19 Thread Mike Kravetz
As hugetlbfs evolved, state information about hugetlb pages was added. One 'convenient' way of doing this was to use available fields in tail pages. Over time, it has become difficult to know the meaning or contents of fields simply by looking at a small bit of code. Sometimes, the naming is