Re: [PATCH v2 1/5] perf/x86: Always store regs->ip in perf_callchain_kernel()

2019-06-14 Thread Song Liu
> On Jun 14, 2019, at 2:16 PM, Steven Rostedt wrote: > > On Fri, 14 Jun 2019 16:06:19 -0500 > Josh Poimboeuf wrote: > >>> It's not cool to remove people's SOB. >>> It's Song's patch. His should be first and your second. >> >> His original patch didn't have an SOB. I preserved the "From"

Re: [PATCH v2 1/5] perf/x86: Always store regs->ip in perf_callchain_kernel()

2019-06-14 Thread Steven Rostedt
On Fri, 14 Jun 2019 16:06:19 -0500 Josh Poimboeuf wrote: > > It's not cool to remove people's SOB. > > It's Song's patch. His should be first and your second. > > His original patch didn't have an SOB. I preserved the "From" field. Then it can't be accepted. It needs an SOB from the

Re: [PATCH v2 1/5] perf/x86: Always store regs->ip in perf_callchain_kernel()

2019-06-14 Thread Josh Poimboeuf
On Fri, Jun 14, 2019 at 01:56:15PM -0700, Alexei Starovoitov wrote: > On Fri, Jun 14, 2019 at 12:56:40PM -0500, Josh Poimboeuf wrote: > > From: Song Liu > > > > The stacktrace_map_raw_tp BPF selftest is failing because the RIP saved > > by perf_arch_fetch_caller_regs() isn't getting saved by > >

Re: [PATCH v2 1/5] perf/x86: Always store regs->ip in perf_callchain_kernel()

2019-06-14 Thread Alexei Starovoitov
On Fri, Jun 14, 2019 at 12:56:40PM -0500, Josh Poimboeuf wrote: > From: Song Liu > > The stacktrace_map_raw_tp BPF selftest is failing because the RIP saved > by perf_arch_fetch_caller_regs() isn't getting saved by > perf_callchain_kernel(). > > This was broken by the following commit: > >

[PATCH v2 1/5] perf/x86: Always store regs->ip in perf_callchain_kernel()

2019-06-14 Thread Josh Poimboeuf
From: Song Liu The stacktrace_map_raw_tp BPF selftest is failing because the RIP saved by perf_arch_fetch_caller_regs() isn't getting saved by perf_callchain_kernel(). This was broken by the following commit: d15d356887e7 ("perf/x86: Make perf callchains work without CONFIG_FRAME_POINTER")