Re: [PATCH v2 1/5] perf cs-etm: Refactor instruction size handling

2019-09-23 Thread Leo Yan
Hi Suzuki, On Mon, Sep 23, 2019 at 05:51:04PM +0100, Suzuki K Poulose wrote: > Hi Leo, > > On 23/09/2019 17:07, Leo Yan wrote: > > In cs-etm.c there have several functions need to know instruction size > > based on address, e.g. cs_etm__instr_addr() and cs_etm__copy_insn() > > these two functions

Re: [PATCH v2 1/5] perf cs-etm: Refactor instruction size handling

2019-09-23 Thread Suzuki K Poulose
Hi Leo, On 23/09/2019 17:07, Leo Yan wrote: In cs-etm.c there have several functions need to know instruction size based on address, e.g. cs_etm__instr_addr() and cs_etm__copy_insn() these two functions both calculate the instruction size separately. Furthermore, if we consider to add new featur

[PATCH v2 1/5] perf cs-etm: Refactor instruction size handling

2019-09-23 Thread Leo Yan
In cs-etm.c there have several functions need to know instruction size based on address, e.g. cs_etm__instr_addr() and cs_etm__copy_insn() these two functions both calculate the instruction size separately. Furthermore, if we consider to add new features later which also might require to calculate